Merge pull request #13542 from igfoo/igfoo/modality_final

igfoo · web-flow · commit 4415c364ac5b · 2023-06-27T15:41:27.000+01:00
Kotlin: Remove an expected-no-getter exception
diff --git a/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt b/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt
@@ -1559,7 +1559,7 @@ open class KotlinFileExtractor(
                 val setter = p.setter
 
                 if (getter == null) {
-                    if (p.modality != Modality.FINAL || !isExternalDeclaration(p)) {
+                    if (!isExternalDeclaration(p)) {
                         logger.warnElement("IrProperty without a getter", p)
                     }
                 } else if (shouldExtractDecl(getter, extractPrivateMembers)) {

Original file line number	Diff line number	Diff line change
`@@ -1559,7 +1559,7 @@ open class KotlinFileExtractor(`
`1559`	`1559`	`val setter = p.setter`
`1560`	`1560`
`1561`	`1561`	`if (getter == null) {`
`1562`		`- if (p.modality != Modality.FINAL \|\| !isExternalDeclaration(p)) {`
	`1562`	`+ if (!isExternalDeclaration(p)) {`
`1563`	`1563`	`logger.warnElement("IrProperty without a getter", p)`
`1564`	`1564`	`}`
`1565`	`1565`	`} else if (shouldExtractDecl(getter, extractPrivateMembers)) {`