Update cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql

bdrodes · MathiasVP · web-flow · commit 45bff1121203 · 2026-02-06T14:46:11.000-05:00
Co-authored-by: Mathias Vorreiter Pedersen &lt;mathiasvp@github.com&gt;
diff --git a/cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql b/cpp/ql/src/Likely Bugs/Leap Year/UncheckedLeapYearAfterYearModification.ql
@@ -123,11 +123,10 @@ class IgnorableExpr48Mapping extends IgnorableOperation {
  */
 class IgnorableCharLiteralArithmetic extends IgnorableOperation {
   IgnorableCharLiteralArithmetic() {
-    exists(this.(BinaryArithmeticOperation).getAnOperand().(TextLiteral).getValue())
+    this.(BinaryArithmeticOperation).getAnOperand() instanceof TextLiteral
     or
-    exists(AssignArithmeticOperation e | e.getRValue() = this |
-      exists(this.(TextLiteral).getValue())
-    )
+    this instanceof TextLiteral and
+    any(AssignArithmeticOperation arith).getRValue() = this
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -123,11 +123,10 @@ class IgnorableExpr48Mapping extends IgnorableOperation {`
`123`	`123`	`*/`
`124`	`124`	`class IgnorableCharLiteralArithmetic extends IgnorableOperation {`
`125`	`125`	`IgnorableCharLiteralArithmetic() {`
`126`		`- exists(this.(BinaryArithmeticOperation).getAnOperand().(TextLiteral).getValue())`
	`126`	`+ this.(BinaryArithmeticOperation).getAnOperand() instanceof TextLiteral`
`127`	`127`	`or`
`128`		`- exists(AssignArithmeticOperation e \| e.getRValue() = this \|`
`129`		`- exists(this.(TextLiteral).getValue())`
`130`		`- )`
	`128`	`+ this instanceof TextLiteral and`
	`129`	`+ any(AssignArithmeticOperation arith).getRValue() = this`
`131`	`130`	`}`
`132`	`131`	`}`
`133`	`132`