Add generic 'browser' as a kind

asgerf · asgerf · commit 4d4f899ec6da · 2026-02-25T09:35:49.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/security/dataflow/RemoteFlowSources.qll b/javascript/ql/lib/semmle/javascript/security/dataflow/RemoteFlowSources.qll
@@ -53,11 +53,17 @@ class ClientSideRemoteFlowKind extends string {
   ClientSideRemoteFlowKind() {
     this =
       [
-        "browser-url-query", "browser-url-fragment", "browser-url-path", "browser-url",
+        "browser", "browser-url-query", "browser-url-fragment", "browser-url-path", "browser-url",
         "browser-window-name", "browser-message-event"
       ]
   }
 
+  /**
+   * Holds if this is the `browser` kind, indicating a remote source in a browser context, that does not fit into one
+   * of the more specific kinds.
+   */
+  predicate isGenericBrowserSourceKind() { this = "browser" }
+
   /**
    * Holds if this is the `browser-url-query` kind, describing sources derived from the query parameters of the browser URL,
    * such as `location.search`.

Original file line number	Diff line number	Diff line change
`@@ -53,11 +53,17 @@ class ClientSideRemoteFlowKind extends string {`
`53`	`53`	`ClientSideRemoteFlowKind() {`
`54`	`54`	`this =`
`55`	`55`	`[`
`56`		`- "browser-url-query", "browser-url-fragment", "browser-url-path", "browser-url",`
	`56`	`+ "browser", "browser-url-query", "browser-url-fragment", "browser-url-path", "browser-url",`
`57`	`57`	`"browser-window-name", "browser-message-event"`
`58`	`58`	`]`
`59`	`59`	`}`
`60`	`60`
	`61`	`+ /**`
	`62`	+ * Holds if this is the `browser` kind, indicating a remote source in a browser context, that does not fit into one
	`63`	`+ * of the more specific kinds.`
	`64`	`+ */`
	`65`	`+ predicate isGenericBrowserSourceKind() { this = "browser" }`
	`66`	`+`
`61`	`67`	`/**`
`62`	`68`	* Holds if this is the `browser-url-query` kind, describing sources derived from the query parameters of the browser URL,
`63`	`69`	* such as `location.search`.