Skip to content

Commit 4f89081

Browse files
committed
Refactor HardcodedCredentials to use new SensitiveApi api
1 parent f7c07d5 commit 4f89081

1 file changed

Lines changed: 4 additions & 9 deletions

File tree

java/ql/lib/semmle/code/java/security/HardcodedCredentials.qll

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,10 @@ abstract class CredentialsSink extends Expr {
5959
*/
6060
class CredentialsApiSink extends CredentialsSink {
6161
CredentialsApiSink() {
62-
exists(Call call, int i |
63-
this = call.getArgument(i) and
64-
(
65-
javaApiCallableUsernameParam(call.getCallee(), i) or
66-
javaApiCallablePasswordParam(call.getCallee(), i) or
67-
javaApiCallableCryptoKeyParam(call.getCallee(), i) or
68-
otherApiCallableCredentialParam(call.getCallee(), i)
69-
)
70-
)
62+
this = any(PasswordParameter p).asExpr() or
63+
this = any(UsernameParameter p).asExpr() or
64+
this = any(CryptoKeyParameter p).asExpr() or
65+
this = any(CredentialParameter p).asExpr()
7166
}
7267
}
7368

0 commit comments

Comments
 (0)