JS: Improve perf of GlobalVarUse.isIncomplete

Author: asgerf

javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll

@@ -1533,7 +1533,7 @@ module DataFlow {
       not e.(Parameter).isRestParameter()
     )
     or
-    nd.(AnalyzedParameter).hasIncompleteness(cause)
+    nd.(AnalyzedNode).hasAdditionalIncompleteness(cause)
     or
     nd.asExpr() instanceof ExternalModuleReference and
     cause = "import"

javascript/ql/src/semmle/javascript/dataflow/TypeInference.qll

@@ -156,6 +156,14 @@ class AnalyzedNode extends DataFlow::Node {
 
   /** Holds if the flow analysis can infer at least one abstract value for this node. */
   predicate hasFlow() { exists(getAValue()) }
+
+  /**
+   * INTERNAL. Use `isIncomplete()` instead.
+   *
+   * Subclasses may override this to contribute additional incompleteness to this node
+   * without overriding `isIncomplete()`.
+   */
+  predicate hasAdditionalIncompleteness(DataFlow::Incompleteness cause) { none() }
 }
 
 /**

javascript/ql/src/semmle/javascript/dataflow/internal/AnalyzedParameters.qll

@@ -34,13 +34,7 @@ class AnalyzedParameter extends AnalyzedValueNode {
     result = astNode.getDefault().analyze().getALocalValue()
   }
 
-  /**
-   * Whether this node should be considered incomplete with the given cause.
-   *
-   * For performance reasons, this is not an override of `isIncomplete`, but is
-   * explicitly included in that predicate.
-   */
-  predicate hasIncompleteness(DataFlow::Incompleteness cause) {
+  override predicate hasAdditionalIncompleteness(DataFlow::Incompleteness cause) {
     getFunction().isIncomplete(cause)
     or
     not getFunction().argumentPassing(astNode, _) and

javascript/ql/src/semmle/javascript/dataflow/internal/VariableTypeInference.qll

@@ -387,9 +387,7 @@ private class AnalyzedGlobalVarUse extends DataFlow::AnalyzedValueNode {
     result.getBase().analyze().getALocalValue() instanceof AbstractGlobalObject
   }
 
-  override predicate isIncomplete(DataFlow::Incompleteness reason) {
-    super.isIncomplete(reason)
-    or
+  override predicate hasAdditionalIncompleteness(DataFlow::Incompleteness reason) {
     clobberedProp(gv, reason)
   }