don't use getEnclosingStmt

erik-krogh · erik-krogh · commit 55565a51df9e · 2020-06-25T23:00:52.000+02:00
diff --git a/javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll b/javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll
@@ -444,7 +444,7 @@ module AccessPath {
           ref = getAccessTo(root, path, _) and
           ref.getBasicBlock() = bb
         |
-          ref order by any(int i | ref.asExpr().getEnclosingStmt() = bb.getNode(i))
+          ref order by any(int i | ref.asExpr() = bb.getNode(i))
         ) and
       result = getAccessTo(root, path, type)
     }

Original file line number	Diff line number	Diff line change
`@@ -444,7 +444,7 @@ module AccessPath {`
`444`	`444`	`ref = getAccessTo(root, path, _) and`
`445`	`445`	`ref.getBasicBlock() = bb`
`446`	`446`	`\|`
`447`		`- ref order by any(int i \| ref.asExpr().getEnclosingStmt() = bb.getNode(i))`
	`447`	`+ ref order by any(int i \| ref.asExpr() = bb.getNode(i))`
`448`	`448`	`) and`
`449`	`449`	`result = getAccessTo(root, path, type)`
`450`	`450`	`}`