Skip to content

Commit 57041aa

Browse files
esbenahenrymercer
authored andcommitted
Apply suggestions from code review
Co-authored-by: Henry Mercer <henrymercer@github.com>
1 parent 5ac608d commit 57041aa

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

javascript/ql/experimental/adaptivethreatmodeling/test/generic_feature_testing/NonFunctionalFeature.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import javascript
22
import experimental.adaptivethreatmodeling.EndpointFeatures
33
import TestUtil
44

5-
// every feature must produce a single value for each endpoint that it computes a value for, otherwise the ML model will be confused(?)
5+
// every feature must produce a single value for each endpoint that it computes a value for, per the contract of the `scoreEndpoints` HOP
66
from Endpoint endpoint, EndpointFeature feature, int arity
77
where arity = count(feature.getValue(endpoint)) and arity > 1
88
select endpoint, feature.getName(), arity

0 commit comments

Comments
 (0)