C#: Update Flow summaries QL test code based on refactor.

Author: michaelnebel

csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.ql

@@ -3,7 +3,7 @@ private import semmle.code.csharp.dataflow.internal.DataFlowPrivate::Csv
 private import semmle.code.csharp.dataflow.ExternalFlow
 
 class IncludeFilteredSummarizedCallable extends IncludeSummarizedCallable {
-  IncludeFilteredSummarizedCallable() { exists(this) }
+  IncludeFilteredSummarizedCallable() { this instanceof SummarizedCallable }
 
   /**
    * Holds if flow is propagated between `input` and `output` and
@@ -13,12 +13,11 @@ class IncludeFilteredSummarizedCallable extends IncludeSummarizedCallable {
   override predicate relevantSummary(
     SummaryComponentStack input, SummaryComponentStack output, boolean preservesValue
   ) {
-    this.propagatesFlow(input, output, preservesValue) and
-    not exists(IncludeSummarizedCallable rsc, SummarizedCallable sc |
-      sc = rsc.asSummarizedCallable() and
-      isBaseCallableOrPrototype(sc) and
-      rsc.propagatesFlow(input, output, preservesValue) and
-      this.asSummarizedCallable().(UnboundCallable).overridesOrImplementsUnbound(sc)
+    this.(SummarizedCallable).propagatesFlow(input, output, preservesValue) and
+    not exists(IncludeSummarizedCallable rsc |
+      isBaseCallableOrPrototype(rsc) and
+      rsc.(SummarizedCallable).propagatesFlow(input, output, preservesValue) and
+      this.(UnboundCallable).overridesOrImplementsUnbound(rsc)
     )
   }
 }

csharp/ql/test/library-tests/frameworks/EntityFramework/FlowSummaries.ql

@@ -3,7 +3,7 @@ import shared.FlowSummaries
 import semmle.code.csharp.dataflow.ExternalFlow as ExternalFlow
 
 private class IncludeEFSummarizedCallable extends IncludeSummarizedCallable {
-  IncludeEFSummarizedCallable() { this.asSummarizedCallable() instanceof EFSummarizedCallable }
+  IncludeEFSummarizedCallable() { this instanceof EFSummarizedCallable }
 }
 
 query predicate sourceNode(DataFlow::Node node, string kind) {

csharp/ql/test/shared/FlowSummaries.qll

@@ -4,12 +4,9 @@ private import semmle.code.csharp.dataflow.internal.DataFlowPrivate
 
 abstract class IncludeSummarizedCallable extends RelevantSummarizedCallable {
   IncludeSummarizedCallable() {
-    this.asSummarizedCallable() =
-      any(Callable c | [c.(Modifiable), c.(Accessor).getDeclaration()].isEffectivelyPublic())
+    [this.(Modifiable), this.(Accessor).getDeclaration()].isEffectivelyPublic()
   }
 
   /** Gets a string representing the callable in semi-colon separated format for use in flow summaries. */
-  final override string getCallableCsv() {
-    result = Csv::asPartialModel(this.asSummarizedCallable())
-  }
+  final override string getCallableCsv() { result = Csv::asPartialModel(this) }
 }