Java: Add explicit filtering for quality queries that should be included in code-quality

tamasvajk · tamasvajk · commit 57f9aa4b1397 · 2025-04-07T10:40:42.000+02:00
diff --git a/java/ql/src/Language Abuse/TypeVariableHidesType.ql b/java/ql/src/Language Abuse/TypeVariableHidesType.ql
@@ -7,6 +7,7 @@
  * @precision medium
  * @id java/type-variable-hides-type
  * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       readability
  *       types
diff --git a/java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql b/java/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
@@ -7,6 +7,7 @@
  * @precision very-high
  * @id java/integer-multiplication-cast-to-long
  * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  *       types
diff --git a/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql b/java/ql/src/Likely Bugs/Collections/WriteOnlyContainer.ql
@@ -6,6 +6,7 @@
  * @precision very-high
  * @id java/unused-container
  * @suites security-and-quality
+ *         quality
  * @tags maintainability
  *       useless-code
  *       external/cwe/cwe-561
diff --git a/java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql b/java/ql/src/Likely Bugs/Comparison/IncomparableEquals.ql
@@ -7,6 +7,7 @@
  * @precision very-high
  * @id java/equals-on-unrelated-types
  * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  */
diff --git a/java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql b/java/ql/src/Likely Bugs/Comparison/InconsistentEqualsHashCode.ql
@@ -7,6 +7,7 @@
  * @precision very-high
  * @id java/inconsistent-equals-and-hashcode
  * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  *       external/cwe/cwe-581
diff --git a/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql b/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
@@ -7,6 +7,7 @@
  * @precision high
  * @id java/unchecked-cast-in-equals
  * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  */
diff --git a/java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql b/java/ql/src/Likely Bugs/Comparison/RefEqBoxed.ql
@@ -7,6 +7,7 @@
  * @precision very-high
  * @id java/reference-equality-of-boxed-types
  * @suites security-and-quality
+ *         quality
  * @tags reliability
  *       correctness
  *       external/cwe/cwe-595
diff --git a/java/ql/src/Likely Bugs/Likely Typos/ContradictoryTypeChecks.ql b/java/ql/src/Likely Bugs/Likely Typos/ContradictoryTypeChecks.ql
@@ -8,6 +8,7 @@
  * @precision very-high
  * @id java/contradictory-type-checks
  * @suites security-and-quality
+ *         quality
  * @tags correctness
  *       logic
  */
diff --git a/java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql b/java/ql/src/Likely Bugs/Likely Typos/SuspiciousDateFormat.ql
@@ -6,6 +6,7 @@
  * @precision high
  * @id java/suspicious-date-format
  * @suites security-and-quality
+ *         quality
  * @tags correctness
  */
 
diff --git a/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql b/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql
@@ -7,6 +7,7 @@
  * @precision high
  * @id java/input-resource-leak
  * @suites security-and-quality
+ *         quality
  * @tags efficiency
  *       correctness
  *       resources
diff --git a/java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql b/java/ql/src/Likely Bugs/Resource Leaks/CloseWriter.ql
@@ -7,6 +7,7 @@
  * @precision high
  * @id java/output-resource-leak
  * @suites security-and-quality
+ *         quality
  * @tags efficiency
  *       correctness
  *       resources
diff --git a/java/ql/src/codeql-suites/java-code-quality.qls b/java/ql/src/codeql-suites/java-code-quality.qls
@@ -1,14 +1,4 @@
 - queries: .
 - include:
-    id:
-      - java/suspicious-date-format
-      - java/integer-multiplication-cast-to-long
-      - java/equals-on-unrelated-types
-      - java/contradictory-type-checks
-      - java/reference-equality-of-boxed-types
-      - java/inconsistent-equals-and-hashcode
-      - java/unchecked-cast-in-equals
-      - java/unused-container
-      - java/input-resource-leak
-      - java/output-resource-leak
-      - java/type-variable-hides-type
+    suites contain:
+    - quality
