Skip to content

Commit 5bc5925

Browse files
committed
Python: Consistenly use "a user-provided value"
ReflectedXss was the only query that used it with the "a"
1 parent 2648e34 commit 5bc5925

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

python/ql/src/Security/CWE-079/ReflectedXss.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ class ReflectedXssConfiguration extends TaintTracking::Configuration {
3434
from ReflectedXssConfiguration config, TaintedPathSource src, TaintedPathSink sink
3535
where config.hasFlowPath(src, sink)
3636
select sink.getSink(), src, sink, "Cross-site scripting vulnerability due to $@.", src.getSource(),
37-
"user-provided value"
37+
"a user-provided value"

python/ql/src/Security/CWE-094/CodeInjection.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ class CodeInjectionConfiguration extends TaintTracking::Configuration {
3434
from CodeInjectionConfiguration config, TaintedPathSource src, TaintedPathSink sink
3535
where config.hasFlowPath(src, sink)
3636
select sink.getSink(), src, sink, "$@ flows to here and is interpreted as code.", src.getSource(),
37-
"User-provided value"
37+
"A user-provided value"

python/ql/test/query-tests/Security/CWE-079/ReflectedXss.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ edges
66
| reflected_xss.py:8:44:8:53 | externally controlled string | reflected_xss.py:8:26:8:53 | externally controlled string |
77
| reflected_xss.py:8:44:8:53 | externally controlled string | reflected_xss.py:8:26:8:53 | externally controlled string |
88
#select
9-
| reflected_xss.py:8:26:8:53 | BinaryExpr | reflected_xss.py:7:18:7:29 | dict of externally controlled string | reflected_xss.py:8:26:8:53 | externally controlled string | Cross-site scripting vulnerability due to $@. | reflected_xss.py:7:18:7:29 | Attribute | user-provided value |
9+
| reflected_xss.py:8:26:8:53 | BinaryExpr | reflected_xss.py:7:18:7:29 | dict of externally controlled string | reflected_xss.py:8:26:8:53 | externally controlled string | Cross-site scripting vulnerability due to $@. | reflected_xss.py:7:18:7:29 | Attribute | a user-provided value |

python/ql/test/query-tests/Security/CWE-094/CodeInjection.expected

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ edges
1010
| code_injection.py:7:34:7:43 | externally controlled string | code_injection.py:7:14:7:44 | externally controlled string |
1111
| code_injection.py:7:34:7:43 | externally controlled string | code_injection.py:7:14:7:44 | externally controlled string |
1212
#select
13-
| code_injection.py:7:14:7:44 | Attribute() | code_injection.py:4:20:4:26 | django.request.HttpRequest | code_injection.py:7:14:7:44 | externally controlled string | $@ flows to here and is interpreted as code. | code_injection.py:4:20:4:26 | request | User-provided value |
13+
| code_injection.py:7:14:7:44 | Attribute() | code_injection.py:4:20:4:26 | django.request.HttpRequest | code_injection.py:7:14:7:44 | externally controlled string | $@ flows to here and is interpreted as code. | code_injection.py:4:20:4:26 | request | A user-provided value |

0 commit comments

Comments
 (0)