Rust: Sort CFG trees and add scope for closures

Author: paldepind

rust/ql/lib/codeql/rust/controlflow/internal/ControlFlowGraphImpl.qll

@@ -59,22 +59,6 @@ module CfgImpl = Make<Location, CfgInput>;
 
 import CfgImpl
 
-class FunctionTree extends LeafTree instanceof Function { }
-
-class BlockExprTree extends StandardPostOrderTree instanceof BlockExpr {
-  override ControlFlowTree getChildNode(int i) {
-    result = super.getStatement(i)
-    or
-    not exists(super.getStatement(i)) and
-    (exists(super.getStatement(i - 1)) or i = 0) and
-    result = super.getTail()
-  }
-}
-
-class CallExprTree extends StandardPostOrderTree instanceof CallExpr {
-  override ControlFlowTree getChildNode(int i) { result = super.getArg(i) }
-}
-
 class BinaryOpExprTree extends StandardPostOrderTree instanceof BinaryOpExpr {
   BinaryOpExprTree() { super.getOp() != "&&" and super.getOp() != "||" }
 
@@ -127,6 +111,44 @@ class LogicalAndBinaryOpExprTree extends PostOrderTree instanceof BinaryOpExpr {
   }
 }
 
+class BlockExprTree extends StandardPostOrderTree instanceof BlockExpr {
+  override ControlFlowTree getChildNode(int i) {
+    result = super.getStatement(i)
+    or
+    not exists(super.getStatement(i)) and
+    (exists(super.getStatement(i - 1)) or i = 0) and
+    result = super.getTail()
+  }
+}
+
+class BreakExprTree extends PostOrderTree instanceof BreakExpr {
+  override predicate propagatesAbnormal(AstNode child) { child = super.getExpr() }
+
+  override predicate first(AstNode node) {
+    first(super.getExpr(), node)
+    or
+    not super.hasExpr() and node = this
+  }
+
+  override predicate succ(AstNode pred, AstNode succ, Completion c) {
+    last(super.getExpr(), pred, c) and succ = this
+  }
+}
+
+class CallExprTree extends StandardPostOrderTree instanceof CallExpr {
+  override ControlFlowTree getChildNode(int i) { result = super.getArg(i) }
+}
+
+class ClosureExprTree extends LeafTree instanceof ClosureExpr { }
+
+class ContinueExprTree extends LeafTree instanceof ContinueExpr { }
+
+class ExprStmtTree extends StandardPostOrderTree instanceof ExprStmt {
+  override ControlFlowTree getChildNode(int i) { i = 0 and result = super.getExpr() }
+}
+
+class FunctionTree extends LeafTree instanceof Function { }
+
 class IfExprTree extends PostOrderTree instanceof IfExpr {
   override predicate first(AstNode node) { first(super.getCondition(), node) }
 
@@ -157,10 +179,6 @@ class IfExprTree extends PostOrderTree instanceof IfExpr {
   }
 }
 
-class ExprStmtTree extends StandardPostOrderTree instanceof ExprStmt {
-  override ControlFlowTree getChildNode(int i) { i = 0 and result = super.getExpr() }
-}
-
 class LetExprTree extends StandardPostOrderTree instanceof LetExpr {
   override ControlFlowTree getChildNode(int i) { i = 0 and result = super.getExpr() }
 }
@@ -173,6 +191,8 @@ class LetStmtTree extends StandardPostOrderTree instanceof LetStmt {
   }
 }
 
+class LiteralExprTree extends LeafTree instanceof LiteralExpr { }
+
 class LoopExprTree extends PostOrderTree instanceof LoopExpr {
   override predicate propagatesAbnormal(AstNode child) { none() }
 
@@ -199,21 +219,9 @@ class LoopExprTree extends PostOrderTree instanceof LoopExpr {
   }
 }
 
-class ReturnExprTree extends PostOrderTree instanceof ReturnExpr {
-  override predicate propagatesAbnormal(AstNode child) { child = super.getExpr() }
-
-  override predicate first(AstNode node) {
-    first(super.getExpr(), node)
-    or
-    not super.hasExpr() and node = this
-  }
-
-  override predicate succ(AstNode pred, AstNode succ, Completion c) {
-    last(super.getExpr(), pred, c) and succ = this
-  }
-}
+class PathExprTree extends LeafTree instanceof PathExpr { }
 
-class BreakExprTree extends PostOrderTree instanceof BreakExpr {
+class ReturnExprTree extends PostOrderTree instanceof ReturnExpr {
   override predicate propagatesAbnormal(AstNode child) { child = super.getExpr() }
 
   override predicate first(AstNode node) {
@@ -227,13 +235,5 @@ class BreakExprTree extends PostOrderTree instanceof BreakExpr {
   }
 }
 
-class ClosureExprTree extends LeafTree instanceof ClosureExpr { }
-
-class ContinueExprTree extends LeafTree instanceof ContinueExpr { }
-
-class LiteralExprTree extends LeafTree instanceof LiteralExpr { }
-
-class PathExprTree extends LeafTree instanceof PathExpr { }
-
 // A leaf tree for unimplemented nodes in the AST.
 class UnimplementedTree extends LeafTree instanceof Unimplemented { }

rust/ql/lib/codeql/rust/controlflow/internal/Scope.qll

@@ -15,6 +15,12 @@ final class FunctionScope extends CfgScope, Function {
   override predicate scopeLast(AstNode node, Completion c) { last(this.getBody(), node, c) }
 }
 
+final class LambdaScope extends CfgScope, ClosureExpr {
+  override predicate scopeFirst(AstNode node) { first(this.getBody(), node) }
+
+  override predicate scopeLast(AstNode node, Completion c) { last(this.getBody(), node, c) }
+}
+
 /**
  * Gets the immediate parent of a non-`AstNode` element `e`.
  *