Ruby: rename some call sites

Author: asgerf

ruby/ql/lib/codeql/ruby/experimental/UnicodeBypassValidationQuery.qll

@@ -91,19 +91,19 @@ class Configuration extends TaintTracking::Configuration {
       // unicode_utils
       exists(API::MethodAccessNode mac |
         mac = API::getTopLevelMember("UnicodeUtils").getMethod(["nfkd", "nfc", "nfd", "nfkc"]) and
-        sink = mac.getParameter(0).asSink()
+        sink = mac.getArgument(0).asSink()
       )
       or
       // eprun
       exists(API::MethodAccessNode mac |
         mac = API::getTopLevelMember("Eprun").getMethod("normalize") and
-        sink = mac.getParameter(0).asSink()
+        sink = mac.getArgument(0).asSink()
       )
       or
       // unf
       exists(API::MethodAccessNode mac |
         mac = API::getTopLevelMember("UNF").getMember("Normalizer").getMethod("normalize") and
-        sink = mac.getParameter(0).asSink()
+        sink = mac.getArgument(0).asSink()
       )
       or
       // ActiveSupport::Multibyte::Chars
@@ -113,7 +113,7 @@ class Configuration extends TaintTracking::Configuration {
               .getMember("Multibyte")
               .getMember("Chars")
               .getMethod("new")
-              .getCallNode() and
+              .asCall() and
         n = cn.getAMethodCall("normalize") and
         sink = cn.getArgument(0)
       )

ruby/ql/lib/codeql/ruby/experimental/ZipSlipCustomizations.qll

@@ -89,7 +89,7 @@ module ZipSlip {
         // If argument refers to a string object, then it's a hardcoded path and
         // this file is safe.
         not zipOpen
-            .getCallNode()
+            .asCall()
             .getArgument(0)
             .getALocalSource()
             .getConstantValue()

ruby/ql/lib/codeql/ruby/frameworks/core/Gem.qll

@@ -24,7 +24,7 @@ module Gem {
 
     GemSpec() {
       this.getExtension() = "gemspec" and
-      specCall = API::root().getMember("Gem").getMember("Specification").getMethod("new") and
+      specCall = API::getTopLevelMember("Gem").getMember("Specification").getMethod("new") and
       specCall.getLocation().getFile() = this
     }
 
@@ -42,7 +42,7 @@ module Gem {
               .getBlock()
               .getParameter(0)
               .getMethod(name + "=")
-              .getParameter(0)
+              .getArgument(0)
               .asSink()
               .asExpr()
               .getExpr()

ruby/ql/lib/codeql/ruby/security/OpenSSL.qll

@@ -597,7 +597,7 @@ private module Digest {
         call = API::getTopLevelMember("OpenSSL").getMember("Digest").getMethod("new")
       |
         this = call.getReturn().getAMethodCall(["digest", "update", "<<"]) and
-        algo.matchesName(call.getCallNode()
+        algo.matchesName(call.asCall()
               .getArgument(0)
               .asExpr()
               .getExpr()
@@ -619,7 +619,7 @@ private module Digest {
     Cryptography::HashingAlgorithm algo;
 
     DigestCallDirect() {
-      this = API::getTopLevelMember("OpenSSL").getMember("Digest").getMethod("digest").getCallNode() and
+      this = API::getTopLevelMember("OpenSSL").getMember("Digest").getMethod("digest").asCall() and
       algo.matchesName(this.getArgument(0).asExpr().getExpr().getConstantValue().getString())
     }