Make tests use config from InlineFlowTest

For InterProceduralDataFlow, it's hard to get it to use InlineFlowTest
because you need to show both the source and the sink, and there are
problems with quoting when the source is already surrounded by quotes.

Author: owen-mc

go/ql/test/library-tests/semmle/go/dataflow/ChannelField/test.expected

@@ -1,3 +1,4 @@
+failures
 edges
 | test.go:9:9:9:11 | selection of c [collection] | test.go:9:7:9:11 | <-... |
 | test.go:13:16:13:16 | definition of s [pointer, c, collection] | test.go:16:2:16:2 | s [pointer, c, collection] |

go/ql/test/library-tests/semmle/go/dataflow/ChannelField/test.ql

@@ -1,18 +1,10 @@
 import go
-import DataFlow::PathGraph
+import TestUtilities.InlineFlowTest
 
-class TestConfig extends DataFlow::Configuration {
-  TestConfig() { this = "test config" }
+module Flow = DataFlow::Global<DefaultFlowConfig>;
 
-  override predicate isSource(DataFlow::Node source) {
-    source.(DataFlow::CallNode).getTarget().getName() = "source"
-  }
+import Flow::PathGraph
 
-  override predicate isSink(DataFlow::Node sink) {
-    sink = any(DataFlow::CallNode c | c.getTarget().getName() = "sink").getAnArgument()
-  }
-}
-
-from DataFlow::PathNode source, DataFlow::PathNode sink, TestConfig c
-where c.hasFlowPath(source, sink)
+from Flow::PathNode source, Flow::PathNode sink
+where Flow::flowPath(source, sink)
 select source, source, sink, "path"

go/ql/test/library-tests/semmle/go/dataflow/InterProceduralDataFlow/Test.expected

@@ -1,3 +1,5 @@
+failures
+#select
 | destructuring.go:6:13:6:21 | "tainted" | destructuring.go:20:11:20:12 | s1 |
 | destructuring.go:6:13:6:21 | "tainted" | destructuring.go:27:11:27:12 | s1 |
 | destructuring.go:11:13:11:26 | "also tainted" | destructuring.go:34:11:34:12 | s3 |

go/ql/test/library-tests/semmle/go/dataflow/InterProceduralDataFlow/Test.ql

@@ -1,23 +1,24 @@
 import go
+import TestUtilities.InlineFlowTest
 
-class MyConfiguration extends DataFlow::Configuration {
-  MyConfiguration() { this = "MyConfiguration" }
-
-  override predicate isSource(DataFlow::Node nd) {
+module Config implements DataFlow::ConfigSig {
+  predicate isSource(DataFlow::Node nd) {
     exists(ValueEntity v, Write w |
       v.getName().matches("source%") and
       w.writes(v, nd)
     )
   }
 
-  override predicate isSink(DataFlow::Node nd) {
+  predicate isSink(DataFlow::Node nd) {
     exists(ValueEntity v, Write w |
       v.getName().matches("sink%") and
       w.writes(v, nd)
     )
   }
 }
 
-from MyConfiguration cfg, DataFlow::Node source, DataFlow::Node sink
-where cfg.hasFlow(source, sink)
+module Flow = DataFlow::Global<Config>;
+
+from DataFlow::Node source, DataFlow::Node sink
+where Flow::flow(source, sink)
 select source, sink

go/ql/test/library-tests/semmle/go/dataflow/PromotedMethods/DataFlowConfig.ql

@@ -1,33 +1,13 @@
 import go
-import TestUtilities.InlineExpectationsTest
+import TestUtilities.InlineFlowTest
 
-class SourceFunction extends Function {
-  SourceFunction() { this.getName() = "source" }
-}
-
-class SinkFunction extends Function {
-  SinkFunction() { this.getName() = "sink" }
-}
-
-class TestConfig extends DataFlow::Configuration {
-  TestConfig() { this = "testconfig" }
-
-  override predicate isSource(DataFlow::Node source) {
-    source = any(SourceFunction f).getACall().getAResult()
-  }
-
-  override predicate isSink(DataFlow::Node sink) {
-    sink = any(SinkFunction f).getACall().getAnArgument()
-  }
-}
+module ValueFlow = DataFlow::Global<DefaultFlowConfig>;
 
 module PromotedMethodsTest implements TestSig {
   string getARelevantTag() { result = "promotedmethods" }
 
   predicate hasActualResult(Location location, string element, string tag, string value) {
-    exists(TestConfig config, DataFlow::Node source, DataFlow::Node sink |
-      config.hasFlow(source, sink)
-    |
+    exists(DataFlow::Node source, DataFlow::Node sink | ValueFlow::flow(source, sink) |
       sink.hasLocationInfo(location.getFile().getAbsolutePath(), location.getStartLine(),
         location.getStartColumn(), location.getEndLine(), location.getEndColumn()) and
       element = sink.toString() and