Merge pull request #10257 from igfoo/igfoo/hasModifier

igfoo · web-flow · commit 710ba3cb147f · 2022-09-01T15:49:06.000+01:00
Java: Correct hasModifier documentation
diff --git a/java/ql/lib/semmle/code/java/Modifier.qll b/java/ql/lib/semmle/code/java/Modifier.qll
@@ -20,7 +20,7 @@ abstract class Modifiable extends Element {
    * For most purposes, the more specialized predicates `isAbstract`, `isPublic`, etc.
    * should be used.
    *
-   * Both this method and those specialized predicates take implicit modifiers into account.
+   * Those specialized predicates also take implicit modifiers into account.
    * For instance, non-default instance methods in interfaces are implicitly
    * abstract, so `isAbstract()` will hold for them even if `hasModifier("abstract")`
    * does not.

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ abstract class Modifiable extends Element {`
`20`	`20`	* For most purposes, the more specialized predicates `isAbstract`, `isPublic`, etc.
`21`	`21`	`* should be used.`
`22`	`22`	`*`
`23`		`- * Both this method and those specialized predicates take implicit modifiers into account.`
	`23`	`+ * Those specialized predicates also take implicit modifiers into account.`
`24`	`24`	`* For instance, non-default instance methods in interfaces are implicitly`
`25`	`25`	* abstract, so `isAbstract()` will hold for them even if `hasModifier("abstract")`
`26`	`26`	`* does not.`