PS: Allow explicit module qualifiers to be selected with the 'instance' path.

Author: MathiasVP

powershell/ql/lib/semmle/code/powershell/ApiGraphs.qll

@@ -647,6 +647,7 @@ module API {
 
     cached
     predicate instanceEdge(Node pred, Node succ) {
+      // An instance of a type
       exists(string qualifiedType | pred = MkType(qualifiedType) |
         exists(DataFlow::ObjectCreationNode objCreation |
           objCreation.getConstructedTypeName() = qualifiedType and
@@ -658,6 +659,15 @@ module API {
           succ = getForwardStartNode(p)
         )
       )
+      or
+      // A use of a module (or static type?)
+      // TODO: Consider implicit module qualiifers and use instance on all of them
+      exists(string qualifiedType, DataFlow::TypeNameNode typeName |
+        pred = MkModule(qualifiedType) and
+        typeName.getTypeName() = qualifiedType
+      |
+        succ = getForwardStartNode(typeName)
+      )
     }
 
     cached

powershell/ql/lib/semmle/code/powershell/frameworks/data/internal/ApiGraphModelsSpecific.qll

@@ -70,10 +70,12 @@ API::Node getExtraNodeFromType(string qualifiedType) {
   qualifiedType = "" and
   result = API::root()
   or
-  // TODO: How to distinguish between these two cases? And do we need to?
+  // TODO: How to distinguish between these cases? And do we need to?
   exists(string mod, string type | parseRelevantType(qualifiedType, mod, type) |
     result = API::mod(qualifiedType)
     or
+    result = API::mod(qualifiedType).getInstance()
+    or
     result = API::mod(mod).getType(type)
   )
 }