Update javascript/ql/lib/semmle/javascript/Routing.qll

asgerf · erik-krogh · web-flow · commit 784991cce567 · 2021-12-15T16:38:38.000+01:00
Co-authored-by: Erik Krogh Kristensen &lt;erik-krogh@github.com&gt;
diff --git a/javascript/ql/lib/semmle/javascript/Routing.qll b/javascript/ql/lib/semmle/javascript/Routing.qll
@@ -303,7 +303,7 @@ module Routing {
     DataFlow::Node getValueImplicitlyStoredInAccessPath(int n, string path) { none() }
   }
 
-  /** Holds if `pred` and `succ` are adjacent siblings. */
+  /** Holds if `pred` and `succ` are adjacent siblings and `succ` is installed after `pred`. */
   private predicate areSiblings(Node pred, Node succ) {
     exists(ValueNode::Range base, int n |
       pred = base.getChild(n) and

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ module Routing {`
`303`	`303`	`DataFlow::Node getValueImplicitlyStoredInAccessPath(int n, string path) { none() }`
`304`	`304`	`}`
`305`	`305`
`306`		- /** Holds if `pred` and `succ` are adjacent siblings. */
	`306`	+ /** Holds if `pred` and `succ` are adjacent siblings and `succ` is installed after `pred`. */
`307`	`307`	`private predicate areSiblings(Node pred, Node succ) {`
`308`	`308`	`exists(ValueNode::Range base, int n \|`
`309`	`309`	`pred = base.getChild(n) and`