Make SensitiveResultReceiver modules private

egregius313 · egregius313 · commit 7b56383b5270 · 2023-04-13T23:08:46.000-04:00
diff --git a/java/ql/lib/semmle/code/java/security/SensitiveResultReceiverQuery.qll b/java/ql/lib/semmle/code/java/security/SensitiveResultReceiverQuery.qll
@@ -51,7 +51,7 @@ deprecated private class SensitiveResultReceiverConf extends TaintTracking::Conf
   }
 }
 
-module SensitiveResultReceiverConfig implements DataFlow::ConfigSig {
+private module SensitiveResultReceiverConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node node) { node.asExpr() instanceof SensitiveExpr }
 
   predicate isSink(DataFlow::Node node) {
@@ -64,7 +64,7 @@ module SensitiveResultReceiverConfig implements DataFlow::ConfigSig {
   predicate allowImplicitRead(DataFlow::Node n, DataFlow::ContentSet c) { isSink(n) and exists(c) }
 }
 
-module SensitiveResultReceiverFlow = TaintTracking::Global<SensitiveResultReceiverConfig>;
+private module SensitiveResultReceiverFlow = TaintTracking::Global<SensitiveResultReceiverConfig>;
 
 /**
  * DEPRECATED: Use `isSensitiveResultReceiver` instead.

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ deprecated private class SensitiveResultReceiverConf extends TaintTracking::Conf`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`-module SensitiveResultReceiverConfig implements DataFlow::ConfigSig {`
	`54`	`+private module SensitiveResultReceiverConfig implements DataFlow::ConfigSig {`
`55`	`55`	`predicate isSource(DataFlow::Node node) { node.asExpr() instanceof SensitiveExpr }`
`56`	`56`
`57`	`57`	`predicate isSink(DataFlow::Node node) {`
`@@ -64,7 +64,7 @@ module SensitiveResultReceiverConfig implements DataFlow::ConfigSig {`
`64`	`64`	`predicate allowImplicitRead(DataFlow::Node n, DataFlow::ContentSet c) { isSink(n) and exists(c) }`
`65`	`65`	`}`
`66`	`66`
`67`		`-module SensitiveResultReceiverFlow = TaintTracking::Global<SensitiveResultReceiverConfig>;`
	`67`	`+private module SensitiveResultReceiverFlow = TaintTracking::Global<SensitiveResultReceiverConfig>;`
`68`	`68`
`69`	`69`	`/**`
`70`	`70`	* DEPRECATED: Use `isSensitiveResultReceiver` instead.