Swift: Add async varant of WKWebView evaluateJavaScript(_:)

d10c · d10c · commit 7b599f5fefec · 2022-11-03T11:16:48.000+01:00
See concurrency note here: https://developer.apple.com/documentation/webkit/wkwebview/1415017-evaluatejavascript See also https://developer.apple.com/documentation/swift/calling-objective-c-apis-asynchronously
diff --git a/swift/ql/src/queries/Security/CWE-094/UnsafeJsEval.ql b/swift/ql/src/queries/Security/CWE-094/UnsafeJsEval.ql
@@ -35,7 +35,7 @@ class WKWebView extends Sink {
       ce.getStaticTarget() =
         getMethodWithQualifiedName("WKWebView",
           [
-            "evaluateJavaScript(_:completionHandler:)",
+            "evaluateJavaScript(_:)", "evaluateJavaScript(_:completionHandler:)",
             "evaluateJavaScript(_:in:in:completionHandler:)",
             "evaluateJavaScript(_:in:contentWorld:)",
             "callAsyncJavaScript(_:arguments:in:in:completionHandler:)",

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ class WKWebView extends Sink {`
`35`	`35`	`ce.getStaticTarget() =`
`36`	`36`	`getMethodWithQualifiedName("WKWebView",`
`37`	`37`	`[`
`38`		`- "evaluateJavaScript(_:completionHandler:)",`
	`38`	`+ "evaluateJavaScript(_:)", "evaluateJavaScript(_:completionHandler:)",`
`39`	`39`	`"evaluateJavaScript(_:in:in:completionHandler:)",`
`40`	`40`	`"evaluateJavaScript(_:in:contentWorld:)",`
`41`	`41`	`"callAsyncJavaScript(_:arguments:in:in:completionHandler:)",`