Ruby: Rename getARhs -> asSink

Author: asgerf

ruby/ql/lib/codeql/ruby/ApiGraphs.qll

@@ -116,12 +116,12 @@ module API {
     /**
      * Gets a data-flow node corresponding the value flowing into this API component.
      */
-    DataFlow::Node getARhs() { Impl::def(this, result) }
+    DataFlow::Node asSink() { Impl::def(this, result) }
 
     /**
      * Gets a data-flow node that may interprocedurally flow to the value escaping into this API component.
      */
-    DataFlow::Node getAValueReachingRhs() { result = Impl::trackDefNode(this.getARhs()) }
+    DataFlow::Node getAValueReachingRhs() { result = Impl::trackDefNode(this.asSink()) }
 
     /**
      * Gets a call to a method on the receiver represented by this API component.

ruby/ql/test/library-tests/dataflow/api-graphs/use.ql

@@ -29,7 +29,7 @@ class ApiUseTest extends InlineExpectationsTest {
       n = a.getAValueReachableFromSource()
       or
       tag = "def" and
-      n = a.getARhs()
+      n = a.asSink()
       or
       tag = "call" and
       n = a.(API::MethodAccessNode).getCallNode()

ruby/ql/test/library-tests/dataflow/summaries/Summaries.ql

@@ -132,15 +132,15 @@ class CustomValueSink extends DefaultValueFlowConf {
   override predicate isSink(DataFlow::Node sink) {
     super.isSink(sink)
     or
-    sink = ModelOutput::getASinkNode("test-sink").getARhs()
+    sink = ModelOutput::getASinkNode("test-sink").asSink()
   }
 }
 
 class CustomTaintSink extends DefaultTaintFlowConf {
   override predicate isSink(DataFlow::Node sink) {
     super.isSink(sink)
     or
-    sink = ModelOutput::getASinkNode("test-sink").getARhs()
+    sink = ModelOutput::getASinkNode("test-sink").asSink()
   }
 }