fix for when the concatenation root is in parentheses

Author: erik-krogh

javascript/ql/src/Expressions/MissingSpaceInAppend.ql

@@ -23,7 +23,7 @@ Expr leftChild(Expr e) {
 }
 
 predicate isInConcat(Expr e) {
-    exists(ParExpr par | par.getExpression() = e)
+    exists(ParExpr par | isInConcat(par) and par.getExpression() = e)
     or 
     exists(AddExpr a | a.getAnOperand() = e)
 }

javascript/ql/test/query-tests/Expressions/MissingSpaceInAppend/MissingSpaceInAppend.expected

@@ -11,4 +11,5 @@
 | missing.js:24:5:24:21 | `missing a space` | This string appears to be missing a space after 'space'. |
 | missing.js:26:5:26:21 | "missing a space" | This string appears to be missing a space after 'space'. |
 | missing.js:28:5:28:21 | `missing a space` | This string appears to be missing a space after 'space'. |
-| missing.js:31:7:31:12 | "h. 0" | This string appears to be missing a space after '0'. |
+| missing.js:30:7:30:21 | "missing space" | This string appears to be missing a space after 'space'. |
+| missing.js:32:7:32:12 | "h. 0" | This string appears to be missing a space after '0'. |

javascript/ql/test/query-tests/Expressions/MissingSpaceInAppend/missing.js

@@ -27,5 +27,6 @@ s = "missing a space" +
     `here`;
 s = `missing a space` +
     `here`;
+s = (("missing space") + "here")
 
 s = (("h. 0" + "h")) + "word"