Merge pull request #3 from asgerf/js/merge_classes

Napalys · web-flow · commit 7fbbf7e4fc3c · 2025-05-02T10:32:53.000+02:00
JS: Avoid duplication with constructor body
diff --git a/javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll b/javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll
@@ -872,6 +872,7 @@ class ClassNode extends DataFlow::ValueNode, DataFlow::SourceNode {
     or
     // Function-style class case
     astNode instanceof Function and
+    not astNode = any(ClassDefinition cls).getConstructor().getBody() and
     function.getFunction() = astNode and
     (
       exists(getAFunctionValueWithPrototype(function))

Original file line number	Diff line number	Diff line change
`@@ -872,6 +872,7 @@ class ClassNode extends DataFlow::ValueNode, DataFlow::SourceNode {`
`872`	`872`	`or`
`873`	`873`	`// Function-style class case`
`874`	`874`	`astNode instanceof Function and`
	`875`	`+ not astNode = any(ClassDefinition cls).getConstructor().getBody() and`
`875`	`876`	`function.getFunction() = astNode and`
`876`	`877`	`(`
`877`	`878`	`exists(getAFunctionValueWithPrototype(function))`