C++: CgiXss

d10c · d10c · commit 7fe3ccdfa1fc · 2025-07-11T14:42:03.000+02:00
diff --git a/cpp/ql/src/Security/CWE/CWE-079/CgiXss.ql b/cpp/ql/src/Security/CWE/CWE-079/CgiXss.ql
@@ -40,8 +40,10 @@ module Config implements DataFlow::ConfigSig {
     node.asCertainDefinition().getUnspecifiedType() instanceof ArithmeticType
   }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 5 selects source.asIndirectExpr (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-079/CgiXss.ql@51:3:51:7)
+  predicate observeDiffInformedIncrementalMode() { any() }
+
+  Location getASelectedSourceLocation(DataFlow::Node source) {
+    exists(QueryString query | result = query.getLocation() | query = source.asIndirectExpr())
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,10 @@ module Config implements DataFlow::ConfigSig {`
`40`	`40`	`node.asCertainDefinition().getUnspecifiedType() instanceof ArithmeticType`
`41`	`41`	`}`
`42`	`42`
`43`		`- predicate observeDiffInformedIncrementalMode() {`
`44`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 5 selects source.asIndirectExpr (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-079/CgiXss.ql@51:3:51:7)`
	`43`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`44`	`+`
	`45`	`+ Location getASelectedSourceLocation(DataFlow::Node source) {`
	`46`	`+ exists(QueryString query \| result = query.getLocation() \| query = source.asIndirectExpr())`
`45`	`47`	`}`
`46`	`48`	`}`
`47`	`49`