Skip to content

Commit 833d1b1

Browse files
committed
JS: fixup mongoose test
1 parent 9d9926f commit 833d1b1

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

javascript/ql/test/query-tests/Security/CWE-089/untyped/SqlInjection.expected

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ nodes
4646
| mongoose.js:21:19:21:26 | req.body |
4747
| mongoose.js:21:19:21:26 | req.body |
4848
| mongoose.js:21:19:21:32 | req.body.title |
49+
| mongoose.js:24:24:24:30 | [query] |
50+
| mongoose.js:24:24:24:30 | [query] |
51+
| mongoose.js:24:25:24:29 | query |
4952
| mongoose.js:27:20:27:24 | query |
5053
| mongoose.js:27:20:27:24 | query |
5154
| mongoose.js:30:25:30:29 | query |
@@ -204,6 +207,7 @@ edges
204207
| mongodb_bodySafe.js:24:19:24:33 | req.query.title | mongodb_bodySafe.js:29:16:29:20 | query |
205208
| mongodb_bodySafe.js:24:19:24:33 | req.query.title | mongodb_bodySafe.js:29:16:29:20 | query |
206209
| mongodb_bodySafe.js:24:19:24:33 | req.query.title | mongodb_bodySafe.js:29:16:29:20 | query |
210+
| mongoose.js:20:11:20:20 | query | mongoose.js:24:25:24:29 | query |
207211
| mongoose.js:20:11:20:20 | query | mongoose.js:27:20:27:24 | query |
208212
| mongoose.js:20:11:20:20 | query | mongoose.js:27:20:27:24 | query |
209213
| mongoose.js:20:11:20:20 | query | mongoose.js:30:25:30:29 | query |
@@ -265,6 +269,7 @@ edges
265269
| mongoose.js:21:19:21:26 | req.body | mongoose.js:21:19:21:32 | req.body.title |
266270
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:20:11:20:20 | query |
267271
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:20:19:20:20 | {} |
272+
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:24:25:24:29 | query |
268273
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:27:20:27:24 | query |
269274
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:27:20:27:24 | query |
270275
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:30:25:30:29 | query |
@@ -321,6 +326,8 @@ edges
321326
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:93:51:93:55 | query |
322327
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:95:46:95:50 | query |
323328
| mongoose.js:21:19:21:32 | req.body.title | mongoose.js:95:46:95:50 | query |
329+
| mongoose.js:24:25:24:29 | query | mongoose.js:24:24:24:30 | [query] |
330+
| mongoose.js:24:25:24:29 | query | mongoose.js:24:24:24:30 | [query] |
324331
| mongooseJsonParse.js:19:11:19:20 | query | mongooseJsonParse.js:23:19:23:23 | query |
325332
| mongooseJsonParse.js:19:11:19:20 | query | mongooseJsonParse.js:23:19:23:23 | query |
326333
| mongooseJsonParse.js:19:19:19:20 | {} | mongooseJsonParse.js:19:11:19:20 | query |
@@ -371,6 +378,7 @@ edges
371378
| mongodb.js:77:14:77:26 | { tags: tag } | mongodb.js:70:13:70:25 | req.query.tag | mongodb.js:77:14:77:26 | { tags: tag } | This query depends on $@. | mongodb.js:70:13:70:25 | req.query.tag | a user-provided value |
372379
| mongodb.js:85:12:85:24 | { tags: tag } | mongodb.js:70:13:70:25 | req.query.tag | mongodb.js:85:12:85:24 | { tags: tag } | This query depends on $@. | mongodb.js:70:13:70:25 | req.query.tag | a user-provided value |
373380
| mongodb_bodySafe.js:29:16:29:20 | query | mongodb_bodySafe.js:24:19:24:33 | req.query.title | mongodb_bodySafe.js:29:16:29:20 | query | This query depends on $@. | mongodb_bodySafe.js:24:19:24:33 | req.query.title | a user-provided value |
381+
| mongoose.js:24:24:24:30 | [query] | mongoose.js:21:19:21:26 | req.body | mongoose.js:24:24:24:30 | [query] | This query depends on $@. | mongoose.js:21:19:21:26 | req.body | a user-provided value |
374382
| mongoose.js:27:20:27:24 | query | mongoose.js:21:19:21:26 | req.body | mongoose.js:27:20:27:24 | query | This query depends on $@. | mongoose.js:21:19:21:26 | req.body | a user-provided value |
375383
| mongoose.js:30:25:30:29 | query | mongoose.js:21:19:21:26 | req.body | mongoose.js:30:25:30:29 | query | This query depends on $@. | mongoose.js:21:19:21:26 | req.body | a user-provided value |
376384
| mongoose.js:33:24:33:28 | query | mongoose.js:21:19:21:26 | req.body | mongoose.js:33:24:33:28 | query | This query depends on $@. | mongoose.js:21:19:21:26 | req.body | a user-provided value |

javascript/ql/test/query-tests/Security/CWE-089/untyped/mongoose.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ app.post('/documents/find', (req, res) => {
2121
query.title = req.body.title;
2222

2323
// NOT OK: query is tainted by user-provided object value
24-
Document.aggregate('type', query);
24+
Document.aggregate([query]);
2525

2626
// NOT OK: query is tainted by user-provided object value
2727
Document.count(query);

0 commit comments

Comments
 (0)