Python: Port OverlyComplexDelMethod.ql

Only trivial test changes.

Author: tausbn

python/ql/src/Functions/OverlyComplexDelMethod.ql

@@ -12,12 +12,11 @@
  */
 
 import python
-private import LegacyPointsTo
+import semmle.python.Metrics
 
-from FunctionValue method
+from FunctionMetrics method
 where
-  exists(ClassValue c |
-    c.declaredAttribute("__del__") = method and
-    method.getScope().(FunctionMetricsWithPointsTo).getCyclomaticComplexity() > 3
-  )
+  method.getName() = "__del__" and
+  method.isMethod() and
+  method.getCyclomaticComplexity() > 3
 select method, "Overly complex '__del__' method."

python/ql/test/query-tests/Functions/general/OverlyComplexDelMethod.expected

@@ -1 +1 @@
-| protocols.py:74:5:74:22 | Function MegaDel.__del__ | Overly complex '__del__' method. |
+| protocols.py:74:5:74:22 | Function __del__ | Overly complex '__del__' method. |