C#: Log warning when chain or certificate is not provided in the validation.

michaelnebel · michaelnebel · commit 86c6df5cbd38 · 2024-12-10T10:35:48.000+01:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
@@ -606,6 +606,7 @@ private bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount,
                     {
                         if (chain is null || cert is null)
                         {
+                            logger.LogWarning("Certificate validation trivially failed due to missing chain or certificate.");
                             return false;
                         }
                         chain.ChainPolicy.TrustMode = X509ChainTrustMode.CustomRootTrust;

Original file line number	Diff line number	Diff line change
`@@ -606,6 +606,7 @@ private bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount,`
`606`	`606`	`{`
`607`	`607`	`if (chain is null \|\| cert is null)`
`608`	`608`	`{`
	`609`	`+ logger.LogWarning("Certificate validation trivially failed due to missing chain or certificate.");`
`609`	`610`	`return false;`
`610`	`611`	`}`
`611`	`612`	`chain.ChainPolicy.TrustMode = X509ChainTrustMode.CustomRootTrust;`