Merge pull request #139 from microsoft/powershell-fix-multiple-cfg-successors

MathiasVP · web-flow · commit 87cbfd191fe3 · 2024-11-08T20:43:59.000+01:00
PS: Fix multiple CFG successors
diff --git a/powershell/ql/lib/semmle/code/powershell/controlflow/internal/ControlFlowGraphImpl.qll b/powershell/ql/lib/semmle/code/powershell/controlflow/internal/ControlFlowGraphImpl.qll
@@ -198,7 +198,7 @@ module Trees {
       exists(Parameter p |
         p =
           rank[i + 1](Parameter cand, int j |
-            cand.hasDefaultValue() and j = cand.getFunctionIndex()
+            cand.hasDefaultValue() and func.getFunctionParameter(j) = cand
           |
             cand order by j
           ) and

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ module Trees {`
`198`	`198`	`exists(Parameter p \|`
`199`	`199`	`p =`
`200`	`200`	`rank[i + 1](Parameter cand, int j \|`
`201`		`- cand.hasDefaultValue() and j = cand.getFunctionIndex()`
	`201`	`+ cand.hasDefaultValue() and func.getFunctionParameter(j) = cand`
`202`	`202`	`\|`
`203`	`203`	`cand order by j`
`204`	`204`	`) and`