Java: update test cases affected by Duration.ofMillis and AtomicReference.set models

Author: Jami Cogswell

java/ql/test/query-tests/Telemetry/SupportedExternalApis/SupportedExternalApis.expected

@@ -6,5 +6,6 @@
 | java.net.URL#openConnection() | 1 |
 | java.net.URL#openStream() | 1 |
 | java.net.URLConnection#getInputStream() | 1 |
+| java.time.Duration#ofMillis(long) | 1 |
 | java.util.Map#put(Object,Object) | 1 |
 | org.apache.commons.io.FileUtils#deleteDirectory(File) | 1 |

java/ql/test/query-tests/Telemetry/SupportedExternalApis/SupportedExternalApis.java

@@ -16,14 +16,14 @@ public static void main(String[] args) throws Exception {
 		Map<String, Object> map = new HashMap<>(); // uninteresting (parameterless constructor)
 		map.put("foo", new Object()); // supported summary
 
-		Duration d = java.time.Duration.ofMillis(1000); // not supported
+		Duration d = java.time.Duration.ofMillis(1000); // supported neutral
 
 		URL github = new URL("https://www.github.com/"); // supported summary
 		InputStream stream = github.openConnection().getInputStream(); // supported source (getInputStream), supported sink (openConnection)
 
 		new FileWriter(new File("foo")); // supported sink (FileWriter), supported summary (File)
 		new URL("http://foo").openStream(); // supported sink (openStream), supported summary (URL)
 
-		FileUtils.deleteDirectory(new File("foo")); // supported negative summary (deleteDirectory), supported summary (File)
+		FileUtils.deleteDirectory(new File("foo")); // supported neutral (deleteDirectory), supported summary (File)
 	}
 }

java/ql/test/query-tests/Telemetry/UnsupportedExternalAPIs/Test.java

@@ -11,12 +11,13 @@ public static void main(String[] args) {
 		Map<String, Object> map = new HashMap<>();
 		map.put("foo", new Object());
 
-		Duration d = java.time.Duration.ofMillis(1000); // not supported
+		Duration d = java.time.Duration.ofMillis(1000); // supported as a neutral model
 
 		long l = "foo".length(); // supported as a neutral model
 
-		AtomicReference<String> ref = new AtomicReference<>(); // not supported
-		ref.set("foo");
+		AtomicReference<String> ref = new AtomicReference<>(); // uninteresting (parameterless constructor)
+		ref.set("foo"); // supported as a summary model
+		ref.toString(); // not supported
 
 		String.class.isAssignableFrom(Object.class); // parameter with generic type, supported as a neutral model
 

java/ql/test/query-tests/Telemetry/UnsupportedExternalAPIs/UnsupportedExternalAPIs.expected

@@ -1,2 +1 @@
-| java.time.Duration#ofMillis(long) | 1 |
-| java.util.concurrent.atomic.AtomicReference#set(Object) | 1 |
+| java.util.concurrent.atomic.AtomicReference#toString() | 1 |