Merge pull request #15614 from tamasvajk/buildless/razor-cleanup

C# Only remove temp files for MVC view generation if needed

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/Razor.cs

@@ -55,7 +55,7 @@ private static void GenerateAnalyzerConfig(IEnumerable<string> cshtmls, string a
         public IEnumerable<string> GenerateFiles(IEnumerable<string> cshtmls, IEnumerable<string> references, string workingDirectory)
         {
             var name = Guid.NewGuid().ToString("N").ToUpper();
-            var tempPath = FileUtils.GetTemporaryWorkingDirectory(out var _);
+            var tempPath = FileUtils.GetTemporaryWorkingDirectory(out var shouldCleanUp);
             var analyzerConfig = Path.Combine(tempPath, $"{name}.txt");
             var dllPath = Path.Combine(tempPath, $"{name}.dll");
             var cscArgsPath = Path.Combine(tempPath, $"{name}.rsp");
@@ -105,21 +105,24 @@ public IEnumerable<string> GenerateFiles(IEnumerable<string> cshtmls, IEnumerabl
             }
             finally
             {
-                DeleteFile(analyzerConfig);
-                DeleteFile(dllPath);
-                DeleteFile(cscArgsPath);
+                if (shouldCleanUp)
+                {
+                    DeleteFile(analyzerConfig);
+                    DeleteFile(dllPath);
+                    DeleteFile(cscArgsPath);
+                }
             }
         }
 
-        private static void DeleteFile(string path)
+        private void DeleteFile(string path)
         {
             try
             {
                 File.Delete(path);
             }
-            catch
+            catch (Exception exc)
             {
-                // Ignore
+                logger.LogWarning($"Failed to delete file {path}: {exc}");
             }
         }
     }