Fix CodeQL warnings

Author: tiferet

javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/ATMConfig.qll

@@ -70,7 +70,7 @@ abstract class AtmConfig extends string {
    * an effective sink, i.e. one considered as a possible sink of flow in the boosted query.
    */
   final predicate isEffectiveSink(JS::DataFlow::Node candidateSink) {
-    not exists(getAReasonSinkExcluded(candidateSink))
+    not exists(this.getAReasonSinkExcluded(candidateSink))
   }
 
   final EndpointCharacteristics::EndpointCharacteristic getAReasonSinkExcluded(
@@ -85,7 +85,7 @@ abstract class AtmConfig extends string {
     or
     exists(EndpointCharacteristics::EndpointFilterCharacteristic specificFilter |
       specificFilter.getEndpoints(candidateSink) and
-      specificFilter.getImplications(getASinkEndpointType(), false, _) and
+      specificFilter.getImplications(this.getASinkEndpointType(), false, _) and
       result = specificFilter
     )
   }

javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/EndpointCharacteristics.qll

@@ -618,8 +618,8 @@ private class ModeledDatabaseAccessCharacteristic extends NosqlInjectionSinkEndp
   }
 }
 
-private class ReceiverIsHTTPRequestExpressionCharacteristic extends NosqlInjectionSinkEndpointFilterCharacteristic {
-  ReceiverIsHTTPRequestExpressionCharacteristic() { this = "receiver is a HTTP request expression" }
+private class ReceiverIsHttpRequestExpressionCharacteristic extends NosqlInjectionSinkEndpointFilterCharacteristic {
+  ReceiverIsHttpRequestExpressionCharacteristic() { this = "receiver is a HTTP request expression" }
 
   override predicate getEndpoints(DataFlow::Node n) {
     exists(DataFlow::CallNode call | n = call.getAnArgument() |
@@ -629,8 +629,8 @@ private class ReceiverIsHTTPRequestExpressionCharacteristic extends NosqlInjecti
   }
 }
 
-private class ReceiverIsHTTPResponseExpressionCharacteristic extends NosqlInjectionSinkEndpointFilterCharacteristic {
-  ReceiverIsHTTPResponseExpressionCharacteristic() {
+private class ReceiverIsHttpResponseExpressionCharacteristic extends NosqlInjectionSinkEndpointFilterCharacteristic {
+  ReceiverIsHttpResponseExpressionCharacteristic() {
     this = "receiver is a HTTP response expression"
   }
 
@@ -698,8 +698,8 @@ abstract private class SqlInjectionSinkEndpointFilterCharacteristic extends Endp
   }
 }
 
-private class PreparedSQLStatementCharacteristic extends SqlInjectionSinkEndpointFilterCharacteristic {
-  PreparedSQLStatementCharacteristic() { this = "prepared SQL statement" }
+private class PreparedSqlStatementCharacteristic extends SqlInjectionSinkEndpointFilterCharacteristic {
+  PreparedSqlStatementCharacteristic() { this = "prepared SQL statement" }
 
   override predicate getEndpoints(DataFlow::Node n) {
     exists(DataFlow::CallNode call | n = call.getAnArgument() |
@@ -721,8 +721,8 @@ private class ArrayCreationCharacteristic extends SqlInjectionSinkEndpointFilter
   }
 }
 
-private class HTMLOrRenderingCharacteristic extends SqlInjectionSinkEndpointFilterCharacteristic {
-  HTMLOrRenderingCharacteristic() { this = "HTML / rendering" }
+private class HtmlOrRenderingCharacteristic extends SqlInjectionSinkEndpointFilterCharacteristic {
+  HtmlOrRenderingCharacteristic() { this = "HTML / rendering" }
 
   override predicate getEndpoints(DataFlow::Node n) {
     exists(DataFlow::CallNode call | n = call.getAnArgument() |