Inline predicate only used once

owen-mc · owen-mc · commit 90c1fc3e0728 · 2025-09-19T07:42:31.000+01:00
diff --git a/go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll b/go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
@@ -844,13 +844,11 @@ module Public {
     insn = getAWrittenInsn()
   }
 
-  predicate hasPostUpdateNode(Node preupd) { insnHasPostUpdateNode(preupd.asInstruction()) }
-
   private class DefaultPostUpdateNode extends PostUpdateNode {
     Node preupd;
 
     DefaultPostUpdateNode() {
-      hasPostUpdateNode(preupd) and
+      insnHasPostUpdateNode(preupd.asInstruction()) and
       (
         preupd = this.(SsaNode).getAUse()
         or

Original file line number	Diff line number	Diff line change
`@@ -844,13 +844,11 @@ module Public {`
`844`	`844`	`insn = getAWrittenInsn()`
`845`	`845`	`}`
`846`	`846`
`847`		`- predicate hasPostUpdateNode(Node preupd) { insnHasPostUpdateNode(preupd.asInstruction()) }`
`848`		`-`
`849`	`847`	`private class DefaultPostUpdateNode extends PostUpdateNode {`
`850`	`848`	`Node preupd;`
`851`	`849`
`852`	`850`	`DefaultPostUpdateNode() {`
`853`		`- hasPostUpdateNode(preupd) and`
	`851`	`+ insnHasPostUpdateNode(preupd.asInstruction()) and`
`854`	`852`	`(`
`855`	`853`	`preupd = this.(SsaNode).getAUse()`
`856`	`854`	`or`