Skip to content

Commit 9245e1c

Browse files
committed
remove CLI sources Library file & qldoc warnings
1 parent 2961b79 commit 9245e1c

2 files changed

Lines changed: 5 additions & 191 deletions

File tree

go/ql/src/experimental/CWE-522-DecompressionBombs/CmdLineFlowSource.qll

Lines changed: 0 additions & 182 deletions
This file was deleted.

go/ql/src/experimental/CWE-522-DecompressionBombs/DecompressionBombs.ql

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,15 @@
1313

1414
import go
1515
import semmle.go.dataflow.Properties
16-
import semmle.go.security.FlowSources
17-
import CmdLineFlowSource
1816
import MultipartAndFormRemoteSource
1917

20-
module DecompressionBombs implements DataFlow::StateConfigSig {
18+
module DecompressionBombsConfig implements DataFlow::StateConfigSig {
2119
class FlowState = DataFlow::FlowState;
2220

2321
predicate isSource(DataFlow::Node source, FlowState state) {
24-
(
22+
2523
source instanceof UntrustedFlowSource
26-
or
27-
source instanceof CmdLineFlowSource
28-
) and
24+
and
2925
state = ""
3026
}
3127

@@ -167,7 +163,7 @@ module DecompressionBombs implements DataFlow::StateConfigSig {
167163
or
168164
exists(DataFlow::Function f, DataFlow::CallNode call |
169165
(
170-
f.hasQualifiedName(["github.com/dsnet/compress/flate"], "NewReader") or
166+
f.hasQualifiedName("github.com/dsnet/compress/flate", "NewReader") or
171167
f.hasQualifiedName(["compress/flate", "github.com/klauspost/compress/flate"],
172168
["NewReaderDict", "NewReader"])
173169
) and
@@ -253,7 +249,7 @@ module DecompressionBombs implements DataFlow::StateConfigSig {
253249
// }
254250
// override predicate isSink(DataFlow::Node sink) { sink instanceof DataFlow::Node }
255251
// }
256-
module DecompressionBombsFlow = TaintTracking::GlobalWithState<DecompressionBombs>;
252+
module DecompressionBombsFlow = TaintTracking::GlobalWithState<DecompressionBombsConfig>;
257253

258254
import DecompressionBombsFlow::PathGraph
259255

0 commit comments

Comments
 (0)