fix mistake in argumentPassing. The type-tracking was not required to be in an end state

erik-krogh · erik-krogh · commit 934e06ca3b50 · 2022-03-04T09:49:42.000+01:00
diff --git a/python/ql/lib/semmle/python/ApiGraphs.qll b/python/ql/lib/semmle/python/ApiGraphs.qll
@@ -658,7 +658,7 @@ module API {
      */
     private predicate argumentPassing(TApiNode base, Label::ApiLabel lbl, DataFlow::Node arg) {
       exists(DataFlow::Node use, DataFlow::LocalSourceNode pred |
-        use(base, use) and pred = trackUseNode(use, _)
+        use(base, use) and pred = trackUseNode(use)
       |
         exists(int i |
           lbl = Label::parameter(i) and

Original file line number	Diff line number	Diff line change
`@@ -658,7 +658,7 @@ module API {`
`658`	`658`	`*/`
`659`	`659`	`private predicate argumentPassing(TApiNode base, Label::ApiLabel lbl, DataFlow::Node arg) {`
`660`	`660`	`exists(DataFlow::Node use, DataFlow::LocalSourceNode pred \|`
`661`		`- use(base, use) and pred = trackUseNode(use, _)`
	`661`	`+ use(base, use) and pred = trackUseNode(use)`
`662`	`662`	`\|`
`663`	`663`	`exists(int i \|`
`664`	`664`	`lbl = Label::parameter(i) and`