Binary: Add more location predicates.

Author: MathiasVP

binary/ql/lib/semmle/code/binary/ast/internal/CilInstructions.qll

@@ -22,6 +22,8 @@ class CilParameter instanceof @il_parameter {
   int getIndex() { il_parameter(this, _, result, _) }
 
   string getName() { il_parameter(this, _, _, result) }
+
+  Location getLocation() { none() } // TODO: Extract
 }
 
 class CilMethod extends @method {
@@ -49,6 +51,8 @@ class CilMethod extends @method {
     result.getMethod() = this and
     result.getIndex() = i
   }
+
+  Location getLocation() { none() } // TODO: Extract
 }
 
 pragma[nomagic]

binary/ql/lib/semmle/code/binary/ast/ir/internal/Instruction0/TranslatedElement.qll

@@ -1,4 +1,5 @@
 private import semmle.code.binary.ast.instructions as Raw
+private import semmle.code.binary.ast.Location
 private import codeql.controlflow.SuccessorType
 private import semmle.code.binary.ast.ir.internal.Tags
 private import InstructionTag
@@ -273,6 +274,8 @@ abstract class TranslatedElement extends TTranslatedElement {
    * Gets the enclosing translated function of this translated element.
    */
   abstract TranslatedFunction getEnclosingFunction();
+
+  abstract Location getLocation();
 }
 
 /**

binary/ql/lib/semmle/code/binary/ast/ir/internal/Instruction0/TranslatedFunction.qll

@@ -1,3 +1,4 @@
+private import semmle.code.binary.ast.Location
 private import semmle.code.binary.ast.instructions as Raw
 private import TranslatedElement
 private import codeql.util.Option
@@ -125,6 +126,8 @@ class TranslatedX86Function extends TranslatedFunction, TTranslatedX86Function {
       r = any(Raw::R9Register r9).getASubRegister*() and ordering = 3
     )
   }
+
+  final override Location getLocation() { result = entry.getLocation() }
 }
 
 class TranslatedCilParameter extends TranslatedElement, TTranslatedCilParameter {
@@ -134,6 +137,8 @@ class TranslatedCilParameter extends TranslatedElement, TTranslatedCilParameter
 
   override Raw::Element getRawElement() { result = p }
 
+  final override Location getLocation() { result = p.getLocation() }
+
   override Variable getResultVariable() { none() }
 
   override TranslatedFunction getEnclosingFunction() {
@@ -182,6 +187,8 @@ class TranslatedCilMethod extends TranslatedFunction, TTranslatedCilMethod {
 
   override Raw::Element getRawElement() { result = method }
 
+  final override Location getLocation() { result = method.getLocation() }
+
   override predicate hasBodyInstruction(
     Opcode opcode, InstructionTag tag, Option<Variable>::Option v
   ) {

binary/ql/lib/semmle/code/binary/ast/ir/internal/Instruction0/TranslatedInstruction.qll

@@ -1,3 +1,4 @@
+private import semmle.code.binary.ast.Location
 private import semmle.code.binary.ast.instructions as Raw
 private import TranslatedElement
 private import semmle.code.binary.ast.ir.internal.Opcode as Opcode
@@ -36,6 +37,8 @@ abstract class TranslatedX86Instruction extends TranslatedInstruction {
   final StackPointer getStackPointer() {
     result = this.getLocalVariable(X86RegisterTag(any(Raw::RspRegister sp)))
   }
+
+  final override Location getLocation() { result = instr.getLocation() }
 }
 
 abstract class TranslatedCilInstruction extends TranslatedInstruction {
@@ -59,6 +62,8 @@ abstract class TranslatedCilInstruction extends TranslatedInstruction {
   final Variable getCilLocalVariable(int index) {
     result = this.getLocalVariable(StlocVarTag(index))
   }
+
+  final override Location getLocation() { result = instr.getLocation() }
 }
 
 /**

binary/ql/lib/semmle/code/binary/ast/ir/internal/Instruction0/TranslatedOperand.qll

@@ -1,3 +1,4 @@
+private import semmle.code.binary.ast.Location
 private import semmle.code.binary.ast.instructions as Raw
 private import TranslatedElement
 private import codeql.util.Option
@@ -40,6 +41,8 @@ abstract class TranslatedX86Operand extends TranslatedOperand {
   }
 
   final override string toString() { result = "Translation of " + op }
+
+  final override Location getLocation() { none() } // TODO: Implement this
 }
 
 TranslatedOperand getTranslatedOperand(Raw::Element op) {