Skip to content

Commit 93ace5b

Browse files
author
Robert Marsh
committed
C++: remove Chi node flow in DefaultTaintTracking
1 parent 7468fac commit 93ace5b

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

cpp/ql/src/semmle/code/cpp/ir/dataflow/DefaultTaintTracking.qll

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,10 +157,8 @@ private predicate instructionTaintStep(Instruction i1, Instruction i2) {
157157
// This is part of the translation of `a[i]`, where we want taint to flow
158158
// from `a`.
159159
i2.(PointerAddInstruction).getLeft() = i1
160-
or
161-
i2.(ChiInstruction).getPartial() = i1
162-
or
163-
i2.(ChiInstruction).getTotal() = i1
160+
// TODO: robust Chi handling
161+
//
164162
// TODO: Flow from argument to return of known functions: Port missing parts
165163
// of `returnArgument` to the `interfaces.Taint` and `interfaces.DataFlow`
166164
// libraries.

0 commit comments

Comments
 (0)