Remove a data flow consistency exclusion

owen-mc · owen-mc · commit 9f4fd7fab0c4 · 2026-04-17T11:27:36.000+01:00
This is no longer needed.
diff --git a/go/ql/lib/semmle/go/dataflow/internal/DataFlowImplConsistency.qll b/go/ql/lib/semmle/go/dataflow/internal/DataFlowImplConsistency.qll
@@ -19,10 +19,6 @@ private module Input implements InputSig<Location, Impl::GoDataFlow> {
 
   predicate uniqueNodeLocationExclude(DataFlow::Node n) { missingLocationExclude(n) }
 
-  predicate localFlowIsLocalExclude(DataFlow::Node n1, DataFlow::Node n2) {
-    n1 instanceof DataFlow::FunctionNode and simpleLocalFlowStep(n1, n2, _)
-  }
-
   predicate argHasPostUpdateExclude(DataFlow::ArgumentNode n) {
     not DataFlow::insnHasPostUpdateNode(n.asInstruction())
   }

Original file line number	Diff line number	Diff line change
`@@ -19,10 +19,6 @@ private module Input implements InputSig<Location, Impl::GoDataFlow> {`
`19`	`19`
`20`	`20`	`predicate uniqueNodeLocationExclude(DataFlow::Node n) { missingLocationExclude(n) }`
`21`	`21`
`22`		`- predicate localFlowIsLocalExclude(DataFlow::Node n1, DataFlow::Node n2) {`
`23`		`- n1 instanceof DataFlow::FunctionNode and simpleLocalFlowStep(n1, n2, _)`
`24`		`- }`
`25`		`-`
`26`	`22`	`predicate argHasPostUpdateExclude(DataFlow::ArgumentNode n) {`
`27`	`23`	`not DataFlow::insnHasPostUpdateNode(n.asInstruction())`
`28`	`24`	`}`