C++: Fix "is constant" check

jbj · jbj · commit 9fc27e913028 · 2020-05-01T09:04:31.000+02:00
The check was supposed to check for constant type, not constant value.
This fixes a false negative that appeared in
`LargeParameter/test.cpp:106`.
diff --git a/cpp/ql/src/semmle/code/cpp/dataflow/EscapesTree.qll b/cpp/ql/src/semmle/code/cpp/dataflow/EscapesTree.qll
@@ -223,7 +223,7 @@ private predicate lvalueMayEscapeMutablyAt(Expr e) {
   lvalueMayEscapeAt(e) and
   // A qualifier of a call to a const member function is converted to a const
   // class type.
-  not e.isConstant()
+  not e.getType().isConst()
 }
 
 private predicate addressFromVariableAccess(VariableAccess va, Expr e) {

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ private predicate lvalueMayEscapeMutablyAt(Expr e) {`
`223`	`223`	`lvalueMayEscapeAt(e) and`
`224`	`224`	`// A qualifier of a call to a const member function is converted to a const`
`225`	`225`	`// class type.`
`226`		`- not e.isConstant()`
	`226`	`+ not e.getType().isConst()`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`private predicate addressFromVariableAccess(VariableAccess va, Expr e) {`