Fixing Test cases

Author: raulgarciamsft

csharp/ql/test/query-tests/Security Features/CWE-327/InsecureSQLConnection/InsecureSQLConnection.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Data.SqlClient;
 
 namespace InsecureSQLConnection
@@ -35,21 +34,21 @@ public void StringInBuilderProperty()
         public void StringInInitializer()
         {
             string connectString = "Server=1.2.3.4;Database=Anything;UID=ab;Pwd=cd;Encrypt=false";
-            SqlConnectionStringBuilder conBuilder = new SqlConnectionStringBuilder(connectString) { Encrypt = true}; // False Positive
+            SqlConnectionStringBuilder conBuilder = new SqlConnectionStringBuilder(connectString) { Encrypt = true };
         }
-        
+
 
         public void TriggerThis()
         {
-            // BAD, Encrypt not specified (version dependent)
+            // BAD, Encrypt not specified
             SqlConnection conn = new SqlConnection("Server=myServerName\\myInstanceName;Database=myDataBase;User Id=myUsername;");
         }
 
         void Test4()
         {
             string connectString =
                 "Server=1.2.3.4;Database=Anything;UID=ab;Pwd=cd";
-            // BAD, Encrypt not specified (version dependent)
+            // BAD, Encrypt not specified
             SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder(connectString);
             var conn = new SqlConnection(builder.ConnectionString);
         }
@@ -62,20 +61,5 @@ void Test5()
             SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder(connectString);
             var conn = new SqlConnection(builder.ConnectionString);
         }
-
-        void Test6()
-        {
-            var conn = new SqlConnectionStringBuilder(SetToTrueConnStr) { Encrypt = false };    // Bug - cs/insecure-sql-connection-initializer
-        }
-
-        void Test72ndPhase(bool encrypt)
-        {
-            var conn = new SqlConnectionStringBuilder(SetToTrueConnStr) { Encrypt = encrypt };    // Bug - cs/insecure-sql-connection-initializer (sink)
-        }
-
-        void Test7()
-        {
-            Test72ndPhase(false);    // Bug - cs/insecure-sql-connection-initializer (source)
-        }
     }
 }

csharp/ql/test/query-tests/Security Features/CWE-327/InsecureSQLConnectionInitializer/InsecureSQLConnection.cs

@@ -0,0 +1,4 @@
+edges
+nodes
+subpaths
+#select