C++: UnsafeCreateProcessCall

Author: d10c

cpp/ql/src/Security/CWE/CWE-428/UnsafeCreateProcessCall.ql

@@ -63,16 +63,14 @@ module NullAppNameCreateProcessFunctionConfig implements DataFlow::ConfigSig {
     )
   }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 101 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-428/UnsafeCreateProcessCall.ql@111:8:111:11)
-  }
+  predicate observeDiffInformedIncrementalMode() { any() }
 
-  Location getASelectedSourceLocation(DataFlow::Node source) {
-    none() // TODO: Make sure that this source location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 101 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-428/UnsafeCreateProcessCall.ql@111:8:111:11)
-  }
+  Location getASelectedSourceLocation(DataFlow::Node source) { none() }
 
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    none() // TODO: Make sure that this sink location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 101 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-428/UnsafeCreateProcessCall.ql@111:8:111:11)
+    exists(CreateProcessFunctionCall call | result = call.getLocation() |
+      sink.asExpr() = call.getArgument(call.getApplicationNameArgumentId())
+    )
   }
 }
 
@@ -95,16 +93,14 @@ module QuotedCommandInCreateProcessFunctionConfig implements DataFlow::ConfigSig
     )
   }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 106 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-428/UnsafeCreateProcessCall.ql@111:8:111:11)
-  }
+  predicate observeDiffInformedIncrementalMode() { any() }
 
-  Location getASelectedSourceLocation(DataFlow::Node source) {
-    none() // TODO: Make sure that this source location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 106 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-428/UnsafeCreateProcessCall.ql@111:8:111:11)
-  }
+  Location getASelectedSourceLocation(DataFlow::Node source) { none() }
 
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    none() // TODO: Make sure that this sink location matches the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 106 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-428/UnsafeCreateProcessCall.ql@111:8:111:11)
+    exists(CreateProcessFunctionCall call | result = call.getLocation() |
+      sink.asExpr() = call.getArgument(call.getCommandLineArgumentId())
+    )
   }
 }