C#: Only extractor locations for source declarations of methods and constructors.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs

@@ -29,7 +29,10 @@ public override void Populate(TextWriter trapFile)
             ContainingType!.PopulateGenerics();
 
             trapFile.constructors(this, Symbol.ContainingType.Name, ContainingType, (Constructor)OriginalDefinition);
-            trapFile.constructor_location(this, Location);
+            if (Context.ExtractLocation(Symbol))
+            {
+                trapFile.constructor_location(this, Location);
+            }
 
             if (MakeSynthetic)
             {

csharp/extractor/Semmle.Extraction.CSharp/Entities/OrdinaryMethod.cs

@@ -43,8 +43,11 @@ public override void Populate(TextWriter trapFile)
                 }
             }
 
-            foreach (var l in Locations)
-                trapFile.method_location(this, l);
+            if (Context.ExtractLocation(Symbol))
+            {
+                foreach (var l in Locations)
+                    trapFile.method_location(this, l);
+            }
 
             PopulateGenerics(trapFile);
             Overrides(trapFile);

csharp/extractor/Semmle.Extraction.CSharp/Extractor/Context.cs

@@ -550,6 +550,10 @@ public bool Defines(ISymbol symbol) =>
             !SymbolEqualityComparer.Default.Equals(symbol, symbol.OriginalDefinition) ||
             scope.InScope(symbol);
 
+        public bool ExtractLocation(ISymbol symbol) =>
+            SymbolEqualityComparer.Default.Equals(symbol, symbol.OriginalDefinition) &&
+            scope.InScope(symbol);
+
         /// <summary>
         /// Runs the given action <paramref name="a"/>, guarding for trap duplication
         /// based on key <paramref name="key"/>.