Update javascript/ql/lib/semmle/javascript/internal/NameResolution.qll

asgerf · erik-krogh · web-flow · commit a6488cbad99a · 2025-06-10T16:06:42.000+02:00
Co-authored-by: Erik Krogh Kristensen &lt;erik-krogh@github.com&gt;
diff --git a/javascript/ql/lib/semmle/javascript/internal/NameResolution.qll b/javascript/ql/lib/semmle/javascript/internal/NameResolution.qll
@@ -312,12 +312,12 @@ module NameResolution {
      */
     private predicate storeToVariable(Expr value, string prop, LocalVariableLike target) {
       exists(AssignExpr assign |
-        // exports.name = value
+        // target.name = value
         assign.getLhs().(PropAccess).accesses(target.getAnAccess(), prop) and
         value = assign.getRhs()
       )
       or
-      // exports = { name: value }
+      // target = { name: value }
       value = target.getAnAssignedExpr().(ObjectExpr).getPropertyByName(prop).getInit()
     }
 

Original file line number	Diff line number	Diff line change
`@@ -312,12 +312,12 @@ module NameResolution {`
`312`	`312`	`*/`
`313`	`313`	`private predicate storeToVariable(Expr value, string prop, LocalVariableLike target) {`
`314`	`314`	`exists(AssignExpr assign \|`
`315`		`- // exports.name = value`
	`315`	`+ // target.name = value`
`316`	`316`	`assign.getLhs().(PropAccess).accesses(target.getAnAccess(), prop) and`
`317`	`317`	`value = assign.getRhs()`
`318`	`318`	`)`
`319`	`319`	`or`
`320`		`- // exports = { name: value }`
	`320`	`+ // target = { name: value }`
`321`	`321`	`value = target.getAnAssignedExpr().(ObjectExpr).getPropertyByName(prop).getInit()`
`322`	`322`	`}`
`323`	`323`