Merge pull request #17843 from github/redsun82/reduce-log-noise

Rust: reduce log spam and skip debug diagnostics in the DB

Author: redsun82

rust/extractor/src/rust_analyzer.rs

@@ -1,5 +1,5 @@
 use itertools::Itertools;
-use log::info;
+use log::{debug, info};
 use ra_ap_base_db::SourceDatabase;
 use ra_ap_base_db::SourceDatabaseFileInputExt;
 use ra_ap_hir::Semantics;
@@ -119,10 +119,21 @@ pub fn find_project_manifests(
         .map(|path| AbsPathBuf::assert_utf8(current.join(path)))
         .collect();
     let ret = ra_ap_project_model::ProjectManifest::discover_all(&abs_files);
-    info!(
-        "found manifests: {}",
-        ret.iter().map(|m| format!("{m}")).join(", ")
-    );
+    let iter = || ret.iter().map(|m| format!("  {m}"));
+    const LOG_LIMIT: usize = 10;
+    if ret.len() <= LOG_LIMIT {
+        info!("found manifests:\n{}", iter().join("\n"));
+    } else {
+        info!(
+            "found manifests:\n{}\nand {} more",
+            iter().take(LOG_LIMIT).join("\n"),
+            ret.len() - LOG_LIMIT
+        );
+        debug!(
+            "rest of the manifests found:\n{}",
+            iter().dropping(LOG_LIMIT).join("\n")
+        );
+    }
     Ok(ret)
 }
 fn from_utf8_lossy(v: &[u8]) -> (Cow<'_, str>, Option<SyntaxError>) {

rust/extractor/src/translate/base.rs

@@ -142,7 +142,7 @@ impl<'a> Translator<'a> {
             self.trap.emit_location(self.label, label, start, end)
         } else {
             self.emit_diagnostic(
-                DiagnosticSeverity::Info,
+                DiagnosticSeverity::Debug,
                 "locations".to_owned(),
                 "missing location for AstNode".to_owned(),
                 "missing location for AstNode".to_owned(),
@@ -169,9 +169,9 @@ impl<'a> Translator<'a> {
     pub fn emit_diagnostic(
         &mut self,
         severity: DiagnosticSeverity,
-        error_tag: String,
-        error_message: String,
-        full_error_message: String,
+        tag: String,
+        message: String,
+        full_message: String,
         location: (LineCol, LineCol),
     ) {
         let (start, end) = location;
@@ -187,16 +187,13 @@ impl<'a> Translator<'a> {
             self.path,
             start.line + 1,
             start.col + 1,
-            &error_message
-        );
-        let location = self.trap.emit_location_label(self.label, start, end);
-        self.trap.emit_diagnostic(
-            severity,
-            error_tag,
-            error_message,
-            full_error_message,
-            location,
+            &message
         );
+        if severity > DiagnosticSeverity::Debug {
+            let location = self.trap.emit_location_label(self.label, start, end);
+            self.trap
+                .emit_diagnostic(severity, tag, message, full_message, location);
+        }
     }
     pub fn emit_parse_error(&mut self, owner: &impl ast::AstNode, err: &SyntaxError) {
         let owner_range: TextRange = owner.syntax().text_range();

rust/extractor/src/trap.rs

@@ -128,7 +128,7 @@ pub struct TrapFile {
     compression: Compression,
 }
 
-#[derive(Copy, Clone)]
+#[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord)]
 pub enum DiagnosticSeverity {
     Debug = 10,
     Info = 20,