Dataflow: Propagate provenance correctly for flow-through wrappers.

aschackmull · aschackmull · commit af06763c4202 · 2024-07-31T14:37:13.000+02:00
diff --git a/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll b/shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
@@ -4526,7 +4526,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
       pathThroughCallable(mid, node, state, cc, t, ap, label) and
       sc = mid.getSummaryCtx() and
       isStoreStep = false and
-      summaryLabel = mid.getSummaryLabel()
+      summaryLabel = mergeLabels(mid.getSummaryLabel(), label)
     }
 
     pragma[nomagic]

Original file line number	Diff line number	Diff line change
`@@ -4526,7 +4526,7 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {`
`4526`	`4526`	`pathThroughCallable(mid, node, state, cc, t, ap, label) and`
`4527`	`4527`	`sc = mid.getSummaryCtx() and`
`4528`	`4528`	`isStoreStep = false and`
`4529`		`- summaryLabel = mid.getSummaryLabel()`
	`4529`	`+ summaryLabel = mergeLabels(mid.getSummaryLabel(), label)`
`4530`	`4530`	`}`
`4531`	`4531`
`4532`	`4532`	`pragma[nomagic]`