C#: Remove special handling of bulk types.

Author: michaelnebel

csharp/ql/src/utils/model-generator/ModelGeneratorUtilsSpecific.qll

@@ -66,14 +66,8 @@ string asPartialModel(TargetApi api) {
  */
 predicate isRelevantType(Type t) { not t instanceof Enum }
 
-private predicate isPrimitiveTypeUsedForBulkData(Type t) {
-  t.getName().regexpMatch("byte|char|Byte|Char")
-}
-
 private string parameterAccess(Parameter p) {
-  if
-    isCollectionType(p.getType()) and
-    not isPrimitiveTypeUsedForBulkData(p.getType().(ArrayType).getElementType())
+  if isCollectionType(p.getType())
   then result = "Argument[" + p.getPosition() + "].Element"
   else result = "Argument[" + p.getPosition() + "]"
 }

csharp/ql/test/utils/model-generator/CaptureSummaryModels.expected

@@ -8,9 +8,6 @@
 | Summaries;BasicFlow;false;ReturnSubstring;(System.String);Argument[0];ReturnValue;taint |
 | Summaries;BasicFlow;false;ReturnThis;(System.Object);Argument[Qualifier];ReturnValue;value |
 | Summaries;BasicFlow;false;SetField;(System.String);Argument[0];Argument[Qualifier];taint |
-| Summaries;BulkArrayFlow;false;AssignFieldToBulkArray;(System.Char[]);Argument[Qualifier];Argument[0];taint |
-| Summaries;BulkArrayFlow;false;AssignToBulkArray;(System.Char[],System.Char);Argument[1];Argument[0];taint |
-| Summaries;BulkArrayFlow;false;ReturnBulkArrayElement;(System.Byte[]);Argument[0];ReturnValue;taint |
 | Summaries;CollectionFlow;false;AddFieldToList;(System.Collections.Generic.List<System.String>);Argument[Qualifier];Argument[0].Element;taint |
 | Summaries;CollectionFlow;false;AddToList;(System.Collections.Generic.List<System.Object>,System.Object);Argument[1];Argument[0].Element;taint |
 | Summaries;CollectionFlow;false;AssignFieldToArray;(System.Object[]);Argument[Qualifier];Argument[0].Element;taint |

csharp/ql/test/utils/model-generator/Summaries.cs

@@ -104,26 +104,6 @@ public IEnumerable<string> ReturnFieldInIEnumerable()
     }
 }
 
-public class BulkArrayFlow
-{
-    private char tainted;
-
-    public void AssignToBulkArray(char[] input, char data)
-    {
-        input[0] = data;
-    }
-
-    public byte ReturnBulkArrayElement(byte[] input)
-    {
-        return input[0];
-    }
-
-    public void AssignFieldToBulkArray(char[] input)
-    {
-        input[0] = tainted;
-    }
-}
-
 public class GenericFlow<T>
 {
     private T tainted;