Skip to content

Commit b3f1a51

Browse files
authored
Update tests
1 parent 74d6061 commit b3f1a51

3 files changed

Lines changed: 96 additions & 65 deletions

File tree

ruby/ql/test/query-tests/experimental/manually-check-http-verb/ExampleController.rb

Lines changed: 0 additions & 48 deletions
This file was deleted.
Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
class ExampleController < ActionController::Base
2+
# Should find
3+
def example_action
4+
if request.get?
5+
Resource.find(id: params[:example_id])
6+
end
7+
end
8+
9+
# Should find
10+
def other_action
11+
if request.env['REQUEST_METHOD'] == "GET"
12+
Resource.find(id: params[:id])
13+
end
14+
end
15+
16+
# Should find
17+
def foo
18+
if request.request_method == "GET"
19+
Resource.find(id: params[:id])
20+
end
21+
end
22+
23+
# Should find
24+
def bar
25+
if request.method == "GET"
26+
Resource.find(id: params[:id])
27+
end
28+
end
29+
30+
# Should find
31+
def baz
32+
if request.raw_request_method == "GET"
33+
Resource.find(id: params[:id])
34+
end
35+
end
36+
37+
# Should find
38+
def foobarbaz
39+
if request.request_method_symbol == :GET
40+
Resource.find(id: params[:id])
41+
end
42+
end
43+
44+
# Should find
45+
def resource_action
46+
case request.env['REQUEST_METHOD']
47+
when "GET"
48+
Resource.find(id: params[:id])
49+
when "POST"
50+
Resource.new(id: params[:id], details: params[:details])
51+
end
52+
end
53+
54+
55+
end
56+
57+
class SafeController < ActionController::Base
58+
# this class should have no hits because controllers rely on conventional Rails routes
59+
def index
60+
Resource.find(id: params[:id])
61+
end
62+
63+
def create
64+
Resource.new(id: params[:id], details: params[:details])
65+
end
66+
67+
def update
68+
Resource.update(id: params[:id], details: params[:details])
69+
end
70+
71+
def delete
72+
s = Resource.find(id: params[:id])
73+
s.delete
74+
end
75+
end
76+
77+
# There should be no hits from this class because it does not inherit from ActionController
78+
class NotAController
79+
def example_action
80+
if request.get?
81+
Resource.find(params[:example_id])
82+
end
83+
end
84+
85+
def resource_action
86+
case env['REQUEST_METHOD']
87+
when "GET"
88+
Resource.find(params[:id])
89+
when "POST"
90+
Resource.new(params[:id], params[:details])
91+
end
92+
end
93+
end
94+
95+
class Resource < ActiveRecord::Base
96+
end

ruby/ql/test/query-tests/experimental/manually-check-http-verb/NotController.rb

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)