PS: Rename a few classes and tests.

Author: MathiasVP

powershell/ql/lib/semmle/code/powershell/NamedAttributeArgument.qll

@@ -7,6 +7,8 @@ class NamedAttributeArgument extends @named_attribute_argument, Ast {
 
   string getName() { named_attribute_argument(this, result, _) }
 
+  predicate hasName(string s) { this.getName() = s }
+
   Expr getValue() { named_attribute_argument(this, _, result) }
 }
 

powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPrivate.qll

@@ -86,7 +86,7 @@ module SsaFlow {
   predicate localFlowStep(SsaImpl::DefinitionExt def, Node nodeFrom, Node nodeTo, boolean isUseStep) {
     Impl::localFlowStep(def, asNode(nodeFrom), asNode(nodeTo), isUseStep) and
     // Flow out of property name parameter nodes are covered by `readStep`.
-    not nodeFrom instanceof PipelineByPropertyNameParameter
+    not nodeFrom instanceof PipelineByPropertyNameParameterNode
   }
 
   predicate localMustFlowStep(SsaImpl::DefinitionExt def, Node nodeFrom, Node nodeTo) {
@@ -501,8 +501,8 @@ private module ParameterNodes {
     override string toStringImpl() { result = parameter.toString() }
   }
 
-  class PipelineByPropertyNameParameter extends NormalParameterNode {
-    PipelineByPropertyNameParameter() { this.getParameter().isPipelineByPropertyName() }
+  class PipelineByPropertyNameParameterNode extends NormalParameterNode {
+    PipelineByPropertyNameParameterNode() { this.getParameter().isPipelineByPropertyName() }
 
     string getPropretyName() { result = this.getParameter().getName() }
   }
@@ -760,8 +760,8 @@ predicate readStep(Node node1, ContentSet c, Node node2) {
   or
   exists(Content::KnownElementContent ec, SsaImpl::DefinitionExt def |
     c.isSingleton(ec) and
-    node1.(PipelineByPropertyNameParameter).getPropretyName() = ec.getIndex().asString() and
-    def.getSourceVariable() = node1.(PipelineByPropertyNameParameter).getParameter() and
+    node1.(PipelineByPropertyNameParameterNode).getPropretyName() = ec.getIndex().asString() and
+    def.getSourceVariable() = node1.(PipelineByPropertyNameParameterNode).getParameter() and
     SsaImpl::firstRead(def, node2.asExpr())
   )
 }
@@ -794,7 +794,7 @@ predicate expectsContent(Node n, ContentSet c) {
   c.isAnyElement()
   or
   exists(Content::KnownElementContent ec |
-    ec.getIndex().asString() = n.(PipelineByPropertyNameParameter).getPropretyName() and
+    ec.getIndex().asString() = n.(PipelineByPropertyNameParameterNode).getPropretyName() and
     c.isSingleton(ec)
   )
 }

powershell/ql/test/library-tests/dataflow/pipeline/test.ps1

@@ -1,40 +1,40 @@
 function produce {
-    $x = Source "16"
-    $y = Source "17"
-    $z = Source "18"
+    $x = Source "1"
+    $y = Source "2"
+    $z = Source "3"
     $x
     $y, $z
 }
 
-function consume {
+function consumeWithProcess {
     Param([Parameter(ValueFromPipeline)] $x)
 
     process {
-        Sink $x # $ hasValueFlow=16 hasValueFlow=17 hasValueFlow=18 hasValueFlow=19 hasValueFlow=20
+        Sink $x # $ hasValueFlow=1 hasValueFlow=2 hasValueFlow=3 hasValueFlow=4 hasValueFlow=5
     }
 }
 
-produce | consume
+produce | consumeWithProcess
 
-$x = Source "19"
-$y = Source "20"
-$x, $y | consume
+$x = Source "4"
+$y = Source "5"
+$x, $y | consumeWithProcess
 
-function consume2 {
+function consumeWithProcessAnonymous {
     process {
-        Sink $_ # $ hasValueFlow=21 hasValueFlow=22
+        Sink $_ # $ hasValueFlow=6 hasValueFlow=7
     }
 }
 
-$x = Source "21"
-$y = Source "22"
-$x, $y | consume2
+$x = Source "6"
+$y = Source "7"
+$x, $y | consumeWithProcessAnonymous
 
-function consumeValueFromPipelineByPropertyName {
+function consumeValueFromPipelineByPropertyNameWithoutProcess {
     Param([Parameter(ValueFromPipelineByPropertyName)] $x)
 
-    Sink $x # $ hasValueFlow=23
+    Sink $x # $ hasValueFlow=8
 }
 
-$x = Source "23"
-[pscustomobject]@{x = $x} | consumeValueFromPipelineByPropertyName
+$x = Source "8"
+[pscustomobject]@{x = $x} | consumeValueFromPipelineByPropertyNameWithoutProcess