JS: support optional options argument to MongoClient.connect

esbena · esbena · commit b6c616efd354 · 2020-03-10T09:57:45.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/NoSQL.qll b/javascript/ql/src/semmle/javascript/frameworks/NoSQL.qll
@@ -44,7 +44,7 @@ private module MongoDB {
   /** Gets a data flow node that leads to a `connect` callback. */
   private DataFlow::SourceNode getAMongoDbCallback(DataFlow::TypeBackTracker t) {
     t.start() and
-    result = getAMongoClient().getAMemberCall("connect").getArgument(1).getALocalSource()
+    result = getAMongoClient().getAMemberCall("connect").getLastArgument().getALocalSource()
     or
     exists(DataFlow::TypeBackTracker t2 | result = getAMongoDbCallback(t2).backtrack(t2, t))
   }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ private module MongoDB {`
`44`	`44`	/** Gets a data flow node that leads to a `connect` callback. */
`45`	`45`	`private DataFlow::SourceNode getAMongoDbCallback(DataFlow::TypeBackTracker t) {`
`46`	`46`	`t.start() and`
`47`		`- result = getAMongoClient().getAMemberCall("connect").getArgument(1).getALocalSource()`
	`47`	`+ result = getAMongoClient().getAMemberCall("connect").getLastArgument().getALocalSource()`
`48`	`48`	`or`
`49`	`49`	`exists(DataFlow::TypeBackTracker t2 \| result = getAMongoDbCallback(t2).backtrack(t2, t))`
`50`	`50`	`}`