C++: simplify TranslatedBlock::getLastChild

Robert Marsh · Robert Marsh · commit b6cf64cff35c · 2024-02-13T00:46:53.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedStmt.qll b/cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedStmt.qll
@@ -674,7 +674,7 @@ class TranslatedBlock extends TranslatedStmt {
   }
 
   override TranslatedElement getLastChild() {
-    not this.isEmpty() and result = this.getStmt(this.getStmtCount() - 1)
+    result = this.getStmt(this.getStmtCount() - 1)
   }
 
   private predicate isEmpty() { not exists(stmt.getStmt(0)) }

Original file line number	Diff line number	Diff line change
`@@ -674,7 +674,7 @@ class TranslatedBlock extends TranslatedStmt {`
`674`	`674`	`}`
`675`	`675`
`676`	`676`	`override TranslatedElement getLastChild() {`
`677`		`- not this.isEmpty() and result = this.getStmt(this.getStmtCount() - 1)`
	`677`	`+ result = this.getStmt(this.getStmtCount() - 1)`
`678`	`678`	`}`
`679`	`679`
`680`	`680`	`private predicate isEmpty() { not exists(stmt.getStmt(0)) }`