Refactored firebase test cases to use inline expectations

Author: Napalys

javascript/ql/test/library-tests/frameworks/Firebase/src/import_assign.ts

@@ -1,5 +1,5 @@
 import firebase = require("firebase");
 
 function test(db: firebase.database.Database) {
-  db.ref("hello");
+  db.ref("hello"); // $firebaseRef
 }

javascript/ql/test/library-tests/frameworks/Firebase/src/import_named.ts

@@ -1,5 +1,5 @@
 import { database } from "firebase";
 
 function test(db: database.Database) {
-  db.ref("hello");
+  db.ref("hello"); // $firebaseRef
 }

javascript/ql/test/library-tests/frameworks/Firebase/src/import_star.ts

@@ -1,5 +1,5 @@
 import * as firebase from "firebase";
 
 function test(db: firebase.database.Database) {
-  db.ref("hello");
+  db.ref("hello"); // $firebaseRef
 }

javascript/ql/test/library-tests/frameworks/Firebase/tests.expected

@@ -1,3 +1,4 @@
+WARNING: type 'FirebaseVal' has been deprecated and may be removed in future (tests.ql:10,29-50)
 firebaseRef
 | src/import_assign.ts:4:3:4:17 | db.ref("hello") |
 | src/import_named.ts:4:3:4:17 | db.ref("hello") |
@@ -20,9 +21,9 @@ firebaseRef
 | tst.js:58:1:58:61 | new Fir ... /news') |
 | tst.js:59:1:59:38 | new Fir ... /news') |
 firebaseSnapshot
-| tst.js:5:1:8:2 | fb.data ... ent;\\n}) |
+| tst.js:5:1:8:2 | fb.data ... eRef\\n}) |
 | tst.js:5:38:5:38 | x |
-| tst.js:10:1:13:2 | admin.d ... ent;\\n}) |
+| tst.js:10:1:13:2 | admin.d ... eRef\\n}) |
 | tst.js:10:41:10:41 | x |
 | tst.js:15:38:15:38 | x |
 | tst.js:20:38:20:38 | x |

javascript/ql/test/library-tests/frameworks/Firebase/tests.qlref

@@ -0,0 +1,2 @@
+query: tests.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql

javascript/ql/test/library-tests/frameworks/Firebase/tst.js

@@ -2,25 +2,25 @@ import * as fb from 'firebase/app';
 import * as admin from 'firebase-admin';
 import * as functions from 'firebase-functions';
 
-fb.database().ref('x').once('value', x => {
-  x.val();
-  x.ref.parent;
-});
+fb.database().ref('x').once('value', x => { // $firebaseSnapshot $firebaseRef
+  x.val(); // $firebaseVal
+  x.ref.parent; // $firebaseRef
+}); // $firebaseSnapshot
 
-admin.database().ref('x').once('value', x => {
-  x.val();
-  x.ref.parent;
-});
+admin.database().ref('x').once('value', x => { // $firebaseSnapshot $firebaseRef
+  x.val(); // $firebaseVal
+  x.ref.parent; // $firebaseRef
+}); // $firebaseSnapshot
 
-functions.database.ref('x').onCreate(x => {
-  x.val();
-  x.ref.parent;
+functions.database.ref('x').onCreate(x => {// $firebaseSnapshot
+  x.val(); // $firebaseVal
+  x.ref.parent; // $firebaseRef
 });
 
-functions.database.ref('x').onUpdate(x => {
-  x.before.val();
-  x.after.val();
-  x.ref.parent;
+functions.database.ref('x').onUpdate(x => { // $firebaseSnapshot
+  x.before.val(); // $firebaseSnapshot $firebaseVal
+  x.after.val(); // $firebaseSnapshot $firebaseVal
+  x.ref.parent; // $firebaseRef
 });
 
 class FirebaseWrapper {
@@ -29,7 +29,7 @@ class FirebaseWrapper {
   }
 
   getRef(x) {
-    return this.firebase.database().ref(x);
+    return this.firebase.database().ref(x); // $firebaseRef
   }
 }
 
@@ -43,22 +43,22 @@ class FirebaseWrapper2 {
   }
 
   getRef(x) {
-    return this.firebase.database().ref(x);
+    return this.firebase.database().ref(x); // $firebaseRef
   }
 
   getNewsItem(x) {
-    return this.getRef(x).child(x).once('value');
+    return this.getRef(x).child(x).once('value'); // $firebaseRef $firebaseSnapshot
   }
 
   adjustValue(fn) {
-    this.firebase.database().ref('x').transaction(fn);
+    this.firebase.database().ref('x').transaction(fn); // $firebaseRef
   }
 }
 
-new FirebaseWrapper(firebase.initializeApp()).getRef('/news');
-new FirebaseWrapper2().getRef('/news');
-new FirebaseWrapper2().getNewsItem('x');
-new FirebaseWrapper2().adjustValue(x => x + 1);
+new FirebaseWrapper(firebase.initializeApp()).getRef('/news'); // $firebaseRef
+new FirebaseWrapper2().getRef('/news'); // $firebaseRef
+new FirebaseWrapper2().getNewsItem('x'); // $firebaseSnapshot
+new FirebaseWrapper2().adjustValue(x => x + 1); // $firebaseVal
 
 class Box {
   constructor(x) {
@@ -69,4 +69,4 @@ let box1 = new Box(fb.database());
 let box2 = new Box(whatever());
 box2.x.ref(); // not a firebase ref
 
-functions.https.onRequest((req, res) => { res.send(req.params.foo); });
+functions.https.onRequest((req, res) => { res.send(req.params.foo); }); // $routeHandler $requestInputAccess $responseSendArgument