C++: Add another example with a type error from binary operations in C code.

Author: MathiasVP

cpp/ql/test/library-tests/ir/ir/PrintAST.expected

@@ -4932,7 +4932,25 @@ ir.c:
 #  103|             Type = [IntType] int
 #  103|             ValueCategory = prvalue(load)
 #  103|       getThen(): [BlockStmt] { ... }
-#  104|     getStmt(16): [ReturnStmt] return ...
+#  105|     getStmt(16): [DeclStmt] declaration
+#  105|       getDeclarationEntry(0): [VariableDeclarationEntry] definition of x
+#  105|           Type = [IntType] int
+#  105|         getVariable().getInitializer(): [Initializer] initializer for x
+#  105|           getExpr(): [LTExpr] ... < ...
+#  105|               Type = [IntType] int
+#  105|               ValueCategory = prvalue
+#  105|             getLesserOperand(): [VariableAccess] x1
+#  105|                 Type = [IntType] int
+#  105|                 ValueCategory = prvalue(load)
+#  105|             getGreaterOperand(): [VariableAccess] x2
+#  105|                 Type = [IntType] int
+#  105|                 ValueCategory = prvalue(load)
+#  106|     getStmt(17): [IfStmt] if (...) ... 
+#  106|       getCondition(): [VariableAccess] x
+#  106|           Type = [IntType] int
+#  106|           ValueCategory = prvalue(load)
+#  106|       getThen(): [BlockStmt] { ... }
+#  107|     getStmt(18): [ReturnStmt] return ...
 ir.cpp:
 #    1| [TopLevelFunction] void Constants()
 #    1|   <params>: 

cpp/ql/test/library-tests/ir/ir/aliased_ir.expected

@@ -3970,8 +3970,28 @@ ir.c:
 #  103|     v103_6(void) = NoOp : 
 #-----|   Goto -> Block 40
 
-#  104|   Block 40
-#  104|     v104_1(void) = NoOp         : 
+#  105|   Block 40
+#  105|     r105_1(glval<int>) = VariableAddress[x]  : 
+#  105|     r105_2(glval<int>) = VariableAddress[x1] : 
+#  105|     r105_3(int)        = Load[x1]            : &:r105_2, m84_6
+#  105|     r105_4(glval<int>) = VariableAddress[x2] : 
+#  105|     r105_5(int)        = Load[x2]            : &:r105_4, m84_8
+#  105|     r105_6(bool)       = CompareLT           : r105_3, r105_5
+#  105|     m105_7(int)        = Store[x]            : &:r105_1, r105_6
+#  106|     r106_1(glval<int>) = VariableAddress[x]  : 
+#  106|     r106_2(int)        = Load[x]             : &:r106_1, m105_7
+#  106|     r106_3(int)        = Constant[0]         : 
+#  106|     r106_4(bool)       = CompareNE           : r106_2, r106_3
+#  106|     v106_5(void)       = ConditionalBranch   : r106_4
+#-----|   False -> Block 42
+#-----|   True -> Block 41
+
+#  106|   Block 41
+#  106|     v106_6(void) = NoOp : 
+#-----|   Goto -> Block 42
+
+#  107|   Block 42
+#  107|     v107_1(void) = NoOp         : 
 #   84|     v84_9(void)  = ReturnVoid   : 
 #   84|     v84_10(void) = AliasedUse   : m84_3
 #   84|     v84_11(void) = ExitFunction : 

cpp/ql/test/library-tests/ir/ir/ir.c

@@ -101,6 +101,9 @@ void branch_on_integral_in_c(int x1, int x2) {
   int x_1_and_2 = x1 && x2;
   if(x_1_and_2) {}
   if(!x_1_and_2) {}
+
+  int x = x1 < x2;
+  if(x) {}
 }
 
 // semmle-extractor-options: --microsoft

cpp/ql/test/library-tests/ir/ir/raw_ir.expected

@@ -3606,8 +3606,28 @@ ir.c:
 #  103|     v103_6(void) = NoOp : 
 #-----|   Goto -> Block 40
 
-#  104|   Block 40
-#  104|     v104_1(void) = NoOp         : 
+#  105|   Block 40
+#  105|     r105_1(glval<int>) = VariableAddress[x]  : 
+#  105|     r105_2(glval<int>) = VariableAddress[x1] : 
+#  105|     r105_3(int)        = Load[x1]            : &:r105_2, ~m?
+#  105|     r105_4(glval<int>) = VariableAddress[x2] : 
+#  105|     r105_5(int)        = Load[x2]            : &:r105_4, ~m?
+#  105|     r105_6(bool)       = CompareLT           : r105_3, r105_5
+#  105|     mu105_7(int)       = Store[x]            : &:r105_1, r105_6
+#  106|     r106_1(glval<int>) = VariableAddress[x]  : 
+#  106|     r106_2(int)        = Load[x]             : &:r106_1, ~m?
+#  106|     r106_3(int)        = Constant[0]         : 
+#  106|     r106_4(bool)       = CompareNE           : r106_2, r106_3
+#  106|     v106_5(void)       = ConditionalBranch   : r106_4
+#-----|   False -> Block 42
+#-----|   True -> Block 41
+
+#  106|   Block 41
+#  106|     v106_6(void) = NoOp : 
+#-----|   Goto -> Block 42
+
+#  107|   Block 42
+#  107|     v107_1(void) = NoOp         : 
 #   84|     v84_8(void)  = ReturnVoid   : 
 #   84|     v84_9(void)  = AliasedUse   : ~m?
 #   84|     v84_10(void) = ExitFunction :