Remove unnecessary fromSource conditions

smowton · smowton · commit bc9eb993b819 · 2024-09-19T15:08:08.000+01:00
diff --git a/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll b/csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
@@ -1011,7 +1011,7 @@ private class CallableUsedInSource extends Callable {
     this.hasBody()
     or
     exists(Callable target |
-      exists(Call c | c.fromSource() |
+      exists(Call c |
         // Note that getADynamicTarget does not always include getTarget.
         target = c.getTarget()
         or
@@ -1022,7 +1022,7 @@ private class CallableUsedInSource extends Callable {
         exists(DispatchCall dc | c = dc.getCall() | target = dc.getADynamicTarget())
       )
       or
-      target = any(CallableAccess ca | ca.fromSource()).getTarget()
+      target = any(CallableAccess ca).getTarget()
     |
       this = target.getUnboundDeclaration()
     )

Original file line number	Diff line number	Diff line change
`@@ -1011,7 +1011,7 @@ private class CallableUsedInSource extends Callable {`
`1011`	`1011`	`this.hasBody()`
`1012`	`1012`	`or`
`1013`	`1013`	`exists(Callable target \|`
`1014`		`- exists(Call c \| c.fromSource() \|`
	`1014`	`+ exists(Call c \|`
`1015`	`1015`	`// Note that getADynamicTarget does not always include getTarget.`
`1016`	`1016`	`target = c.getTarget()`
`1017`	`1017`	`or`
`@@ -1022,7 +1022,7 @@ private class CallableUsedInSource extends Callable {`
`1022`	`1022`	`exists(DispatchCall dc \| c = dc.getCall() \| target = dc.getADynamicTarget())`
`1023`	`1023`	`)`
`1024`	`1024`	`or`
`1025`		`- target = any(CallableAccess ca \| ca.fromSource()).getTarget()`
	`1025`	`+ target = any(CallableAccess ca).getTarget()`
`1026`	`1026`	`\|`
`1027`	`1027`	`this = target.getUnboundDeclaration()`
`1028`	`1028`	`)`